43769d6cc7
Previously when listing images via v2, the first image of each batch was validated against the v2 schema. This could lead to unpredictable behaviour where a particular image which failed the schema check may or may not be the first of a batch. In some cases it also meant that operation by one user could affect the ability of another other to list images. Change-Id: I22974a3e3d9cbdd254099780752ae45ff2a557af Closes-bug: 1477910
59 lines
2.5 KiB
Python
59 lines
2.5 KiB
Python
# Copyright (c) 2015 OpenStack Foundation
|
|
# Copyright (c) 2015 Hewlett-Packard Development Company, L.P.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from requests_mock.contrib import fixture as rm_fixture
|
|
|
|
from glanceclient import client
|
|
from glanceclient.tests.unit.v2.fixtures import image_list_fixture
|
|
from glanceclient.tests.unit.v2.fixtures import image_show_fixture
|
|
from glanceclient.tests.unit.v2.fixtures import schema_fixture
|
|
from glanceclient.tests import utils as testutils
|
|
|
|
|
|
class ClientTestRequests(testutils.TestCase):
|
|
"""Client tests using the requests mock library."""
|
|
|
|
def test_list_bad_image_schema(self):
|
|
# if kernel_id or ramdisk_id are not uuids, verify we can
|
|
# still perform an image listing. Regression test for bug
|
|
# 1477910
|
|
self.requests = self.useFixture(rm_fixture.Fixture())
|
|
self.requests.get('http://example.com/v2/schemas/image',
|
|
json=schema_fixture)
|
|
self.requests.get('http://example.com/v2/images?limit=20',
|
|
json=image_list_fixture)
|
|
gc = client.Client(2.2, "http://example.com/v2.1")
|
|
images = gc.images.list()
|
|
for image in images:
|
|
pass
|
|
|
|
def test_show_bad_image_schema(self):
|
|
# if kernel_id or ramdisk_id are not uuids, verify we
|
|
# fail schema validation on 'show'
|
|
self.requests = self.useFixture(rm_fixture.Fixture())
|
|
self.requests.get('http://example.com/v2/schemas/image',
|
|
json=schema_fixture)
|
|
self.requests.get('http://example.com/v2/images/%s'
|
|
% image_show_fixture['id'],
|
|
json=image_show_fixture)
|
|
gc = client.Client(2.2, "http://example.com/v2.1")
|
|
try:
|
|
gc.images.get(image_show_fixture['id'])
|
|
self.fail('Expected exception was not raised.')
|
|
except ValueError as e:
|
|
if 'ramdisk_id' not in str(e) and 'kernel_id' not in str(e):
|
|
self.fail('Expected exception message was not returned.')
|