openstack/python-heatclient
Code Issues Proposed changes

Merge "Require int value for --limit option"

Browse Source
This commit is contained in:
Zuul
2024-11-16 17:20:24 +00:00
committed by Gerrit Code Review
parent f589ad7ea2 93411beff0
commit bc6fa63c9c
3 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
heatclient/osc/v1/software_config.py
View File

@@ -80,6 +80,7 @@ class ListConfig(command.Lister):
parser.add_argument( parser.add_argument(
'--limit', '--limit',
metavar='<limit>', metavar='<limit>',
type=int,
help=_('Limit the number of configs returned') help=_('Limit the number of configs returned')
) )
parser.add_argument( parser.add_argument(

1
heatclient/osc/v1/stack.py
View File

@@ -537,6 +537,7 @@ class ListStack(command.Lister):
parser.add_argument( parser.add_argument(
'--limit', '--limit',
metavar='<limit>', metavar='<limit>',
type=int,
help=_('The number of stacks returned') help=_('The number of stacks returned')
) )
parser.add_argument( parser.add_argument(

2
heatclient/tests/unit/osc/v1/test_software_config.py
View File

@@ -83,7 +83,7 @@ class TestListConfig(TestConfig):
arglist = ['--limit', '3'] arglist = ['--limit', '3']
parsed_args = self.check_parser(self.cmd, arglist, []) parsed_args = self.check_parser(self.cmd, arglist, [])
self.cmd.take_action(parsed_args) self.cmd.take_action(parsed_args)
self.mock_client.software_configs.list.assert_called_with(limit='3') self.mock_client.software_configs.list.assert_called_with(limit=3)
def test_config_list_marker(self): def test_config_list_marker(self):
arglist = ['--marker', 'id123'] arglist = ['--marker', 'id123']