From a0dfe0703b5966bfc9fb9f4c88564e4f527430fb Mon Sep 17 00:00:00 2001 From: blue55 Date: Thu, 22 Jun 2017 11:18:45 +0800 Subject: [PATCH] Enable some off-by-default checks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some of the available checks are disabled by default, like: [H106] Don’t put vim configuration in source files [H203] Use assertIs(Not)None to check for None Change-Id: I815f189258356cb911d1e232b6f53c864e53c602 --- heatclient/tests/unit/test_utils.py | 3 +-- tox.ini | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/heatclient/tests/unit/test_utils.py b/heatclient/tests/unit/test_utils.py index 34918162..0cb1462d 100644 --- a/heatclient/tests/unit/test_utils.py +++ b/heatclient/tests/unit/test_utils.py @@ -415,8 +415,7 @@ class TestURLFunctions(testtools.TestCase): tmpl_url) self.assertEqual(utils.get_template_url(None, tmpl_url), tmpl_url) - self.assertEqual(utils.get_template_url(None, None), - None) + self.assertIsNone(utils.get_template_url(None, None)) def test_base_url_for_url(self): self.assertEqual( diff --git a/tox.ini b/tox.ini index 8b6026ba..4ac50ea7 100644 --- a/tox.ini +++ b/tox.ini @@ -49,6 +49,7 @@ commands= [flake8] show-source = True +enable-extensions = H203,H106 exclude=.venv,.git,.tox,dist,*lib/python*,*egg,build max-complexity=20