openstack/python-heatclient
Code Issues Proposed changes

Fix and enable Hacking H501 warning

Browse Source 
Enable Gating on H501. Fix the only two cases
that trigger.

Change-Id: Ib309b989df6556d7436e718e1497ce4dcacc83d6
This commit is contained in:
Dirk Mueller
2013-09-02 21:39:21 +02:00
parent a5d71080ef
commit d48d3587bd
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
heatclient/common/http.py
View File

@@ -148,11 +148,13 @@ class HTTPClient(object):
conn.request(method, conn_url, **kwargs) conn.request(method, conn_url, **kwargs)
resp = conn.getresponse() resp = conn.getresponse()
except socket.gaierror as e: except socket.gaierror as e:
message = "Error finding address for %(url)s: %(e)s" % locals() message = ("Error finding address for %(url)s: %(e)s" %
{'url': url, 'e': e})
raise exc.InvalidEndpoint(message=message) raise exc.InvalidEndpoint(message=message)
except (socket.error, socket.timeout) as e: except (socket.error, socket.timeout) as e:
endpoint = self.endpoint endpoint = self.endpoint
message = "Error communicating with %(endpoint)s %(e)s" % locals() message = ("Error communicating with %(endpoint)s %(e)s" %
{'endpoint': endpoint, 'e': e})
raise exc.CommunicationError(message=message) raise exc.CommunicationError(message=message)
body_iter = ResponseBodyIterator(resp) body_iter = ResponseBodyIterator(resp)

2
tox.ini
View File

@@ -22,6 +22,6 @@ downloadcache = ~/cache/pip
[flake8] [flake8]
show-source = True show-source = True
ignore = H233,H302,H501 ignore = H233,H302
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build