openstack
/
python-ironicclient
Code Issues Proposed changes

Merge "Add node.states() to the client library"

This commit is contained in:
Jenkins 2014-02-13 06:50:02 +00:00 committed by Gerrit Code Review
parent 55d004322d 11f56cca61
commit a7f2ee901e
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ironicclient/tests/v1/test_node.py
View File

@ -53,6 +53,12 @@ DRIVER_IFACES = {'deploy': {'result': True},
'console': {'result': None, 'reason': 'not supported'},
'rescue': {'result': None, 'reason': 'not supported'}}
NODE_STATES = {"last_error": None,
"power_state": "power on",
"provision_state": "active",
"target_power_state": None,
"target_provision_state": None}
CREATE_NODE = copy.deepcopy(NODE1)
del CREATE_NODE['id']
del CREATE_NODE['uuid']
@ -144,6 +150,13 @@ fake_responses = {
None,
),
},
'/v1/nodes/%s/states' % NODE1['uuid']:
{
'GET': (
{},
NODE_STATES,
),
},
}
@ -263,3 +276,14 @@ class NodeManagerTest(testtools.TestCase):
('PUT', '/v1/nodes/%s/states/provision' % NODE1['uuid'], {}, body),
]
self.assertEqual(expect, self.api.calls)
def test_node_states(self):
states = self.mgr.states(NODE1['uuid'])
expect = [
('GET', '/v1/nodes/%s/states' % NODE1['uuid'], {}, None),
]
self.assertEqual(expect, self.api.calls)
expected_fields = ['last_error', 'power_state', 'provision_state',
'target_power_state', 'target_provision_state']
self.assertEqual(sorted(expected_fields),
sorted(states.to_dict().keys()))

4
ironicclient/v1/node.py
View File

@ -94,3 +94,7 @@ class NodeManager(base.Manager):
path = "%s/states/provision" % node_uuid
target = {'target': state}
return self._update(self._path(path), target, method='PUT')
def states(self, node_uuid):
path = "%s/states" % node_uuid
return self.get(path)