From d55e36390461c98c961d64f483c7d011af74a3ed Mon Sep 17 00:00:00 2001
From: M V P Nitesh <m.nitesh@nectechnologies.in>
Date: Thu, 9 Feb 2017 19:22:23 +0530
Subject: [PATCH] OSC 'node list' recognizes all provision states

Now OSC 'node list' command with --provision-state argument for
'available' will list all nodes whose provision state is 'available'.
It will also accept all the provision-states for OSC 'node list'
command.

Change-Id: If0032f652bcb3f6638b59dba32b97cb19176df46
Closes-Bug: #1663202
---
 ironicclient/osc/v1/baremetal_node.py                |  4 +---
 .../tests/unit/osc/v1/test_baremetal_node.py         | 12 ------------
 ...sc-node-list-provisionstate-cd98dbddaad93e96.yaml |  4 ++++
 3 files changed, 5 insertions(+), 15 deletions(-)
 create mode 100644 releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml

diff --git a/ironicclient/osc/v1/baremetal_node.py b/ironicclient/osc/v1/baremetal_node.py
index e4cd1d42f..da9ab65cf 100755
--- a/ironicclient/osc/v1/baremetal_node.py
+++ b/ironicclient/osc/v1/baremetal_node.py
@@ -564,9 +564,7 @@ class ListBaremetalNode(command.Lister):
             '--provision-state',
             dest='provision_state',
             metavar='<provision state>',
-            choices=self.PROVISION_STATES,
-            help=_("Limit list to nodes in <provision state>. One of %s.") %
-                 (", ".join(self.PROVISION_STATES)))
+            help=_("List nodes in specified provision state."))
         parser.add_argument(
             '--resource-class',
             dest='resource_class',
diff --git a/ironicclient/tests/unit/osc/v1/test_baremetal_node.py b/ironicclient/tests/unit/osc/v1/test_baremetal_node.py
index 55d70eacb..dea2cff6d 100644
--- a/ironicclient/tests/unit/osc/v1/test_baremetal_node.py
+++ b/ironicclient/tests/unit/osc/v1/test_baremetal_node.py
@@ -778,18 +778,6 @@ class TestBaremetalList(TestBaremetal):
             **kwargs
         )
 
-    def test_baremetal_list_invalid_provision_state(self):
-        arglist = [
-            '--provision-state', 'invalid',
-        ]
-        verifylist = [
-            ('provision_state', 'invalid'),
-        ]
-
-        self.assertRaises(oscutils.ParserException,
-                          self.check_parser,
-                          self.cmd, arglist, verifylist)
-
     def test_baremetal_list_resource_class(self):
         arglist = [
             '--resource-class', 'foo',
diff --git a/releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml b/releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml
new file mode 100644
index 000000000..e56fa9098
--- /dev/null
+++ b/releasenotes/notes/osc-node-list-provisionstate-cd98dbddaad93e96.yaml
@@ -0,0 +1,4 @@
+---
+fixes:
+  - Allows all provision states for OSC node list
+    command with --provision-state argument