From 316d69ef25a1dfc11160ef2a19e0a59c28b03fa8 Mon Sep 17 00:00:00 2001 From: Luong Anh Tuan Date: Mon, 26 Sep 2016 16:52:01 +0700 Subject: [PATCH] Avoid string interpolation in logging calls It's better to delegate the string formatting to the logging module because it will be interpolate the string only if that log level is enabled, saving few CPU cycles. Change-Id: I7cee482de3e9505a353624337befc1e1b7b33416 --- ironicclient/osc/v1/baremetal_chassis.py | 4 ++-- ironicclient/osc/v1/baremetal_driver.py | 2 +- ironicclient/osc/v1/baremetal_node.py | 4 ++-- ironicclient/osc/v1/baremetal_port.py | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ironicclient/osc/v1/baremetal_chassis.py b/ironicclient/osc/v1/baremetal_chassis.py index 6bb8fc13c..f26036304 100644 --- a/ironicclient/osc/v1/baremetal_chassis.py +++ b/ironicclient/osc/v1/baremetal_chassis.py @@ -151,7 +151,7 @@ class ListBaremetalChassis(command.Lister): return parser def take_action(self, parsed_args): - self.log.debug("take_action(%s)" % parsed_args) + self.log.debug("take_action(%s)", parsed_args) client = self.app.client_manager.baremetal columns = res_fields.CHASSIS_RESOURCE.fields @@ -176,7 +176,7 @@ class ListBaremetalChassis(command.Lister): labels = resource.labels params['fields'] = columns - self.log.debug("params(%s)" % params) + self.log.debug("params(%s)", params) data = client.chassis.list(**params) data = oscutils.sort_items(data, parsed_args.sort) diff --git a/ironicclient/osc/v1/baremetal_driver.py b/ironicclient/osc/v1/baremetal_driver.py index d7aafdbe7..4159913f5 100644 --- a/ironicclient/osc/v1/baremetal_driver.py +++ b/ironicclient/osc/v1/baremetal_driver.py @@ -33,7 +33,7 @@ class ListBaremetalDriver(command.Lister): return parser def take_action(self, parsed_args): - self.log.debug("take_action(%s)" % parsed_args) + self.log.debug("take_action(%s)", parsed_args) client = self.app.client_manager.baremetal labels = ['Supported driver(s)', 'Active host(s)'] diff --git a/ironicclient/osc/v1/baremetal_node.py b/ironicclient/osc/v1/baremetal_node.py index d907cb18c..bf86aa170 100644 --- a/ironicclient/osc/v1/baremetal_node.py +++ b/ironicclient/osc/v1/baremetal_node.py @@ -497,7 +497,7 @@ class ListBaremetalNode(command.Lister): return parser def take_action(self, parsed_args): - self.log.debug("take_action(%s)" % parsed_args) + self.log.debug("take_action(%s)", parsed_args) client = self.app.client_manager.baremetal columns = res_fields.NODE_RESOURCE.fields @@ -532,7 +532,7 @@ class ListBaremetalNode(command.Lister): labels = resource.labels params['fields'] = columns - self.log.debug("params(%s)" % params) + self.log.debug("params(%s)", params) data = client.node.list(**params) data = oscutils.sort_items(data, parsed_args.sort) diff --git a/ironicclient/osc/v1/baremetal_port.py b/ironicclient/osc/v1/baremetal_port.py index e5e2fc0e8..4b33a05e6 100644 --- a/ironicclient/osc/v1/baremetal_port.py +++ b/ironicclient/osc/v1/baremetal_port.py @@ -77,7 +77,7 @@ class CreateBaremetalPort(command.ShowOne): return parser def take_action(self, parsed_args): - self.log.debug("take_action(%s)" % parsed_args) + self.log.debug("take_action(%s)", parsed_args) baremetal_client = self.app.client_manager.baremetal if parsed_args.local_link_connection_deprecated: @@ -341,7 +341,7 @@ class ListBaremetalPort(command.Lister): return parser def take_action(self, parsed_args): - self.log.debug("take_action(%s)" % parsed_args) + self.log.debug("take_action(%s)", parsed_args) client = self.app.client_manager.baremetal columns = res_fields.PORT_RESOURCE.fields @@ -373,7 +373,7 @@ class ListBaremetalPort(command.Lister): labels = resource.labels params['fields'] = columns - self.log.debug("params(%s)" % params) + self.log.debug("params(%s)", params) data = client.port.list(**params) data = oscutils.sort_items(data, parsed_args.sort)