Updates hacking to latest, 6.0.0. Updates other deps to permit
coinstallability. No code changes needed.
Change-Id: Ib0b277e3c6b318cc0a24b5532dedd925fbe1ffc6
Per ClarkB on the list, overriding install_command makes it more
difficult to troubleshoot failing CI.
Change-Id: I3e1a7ddac620ba2418d5e9038183848969a1afb2
The lower-constraints test was removed because of an issue where pip
could not correctly determine the required packages versions to install,
ending in an almost infinite loop that would end up in timeout, failure,
and general mayhem.
Recently the issue has been fixed and, if properly configured, the
lower-constraints test can provide good indication of which minimum
versions are required to support the current code.
This patch adds the test back to the current development branch, and it
runs only on master.
The lower-constraints file will stay in the future stable branches.
Adjust min versions in requirements.txt accordingly.
Change-Id: I3678c29fb090244f5e00208e4dcc8f1ad8a54ff5
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.
Change-Id: Ia6ed4853f4fae465e102ce93ad39ee915cc02847
As recommended, since version 3.2.0 tox switches pip invocations
to use the module -m pip instead of direct invocation.
We set min version to 3.2.1 [1] to also fix the behavior of
--parallel--safe-build
[1] https://tox.readthedocs.io/en/latest/changelog.html#v3-2-1-2018-08-10
Change-Id: I5101dcffa0ea9d44507d25b1a8519d710404deb3
Restore pep 8check for import order.
Set flake8-import-order version to 0.17.1
Full py3 compatible version.
Add all Python3 modules to stdlib list.
Also includes fix to an enum34 dependency bug.
Change-Id: I989a84e362a18225c6f79580b22bb028d3e265ff
The new version enables a lot of standard flake8 checks, so a few
fixes are required. W503 is disabled as it conflicts with W504
and the latter seems to be preferred nowadays.
Change-Id: I7c66f18be46af73a47919deef1f38c1f1d3cc741
Since removing support for Python 2, we changed the basepython
value to 3.
This means that all the tox tests run with the default python
version available in the system.
This is not quite correct when running on environment such as
py36, py37 or py38, since they imply running with different
Python versions based on the environment.
To enforce the correct version we need to add the option
ignore_basepython_conflict available since tox 3.1.0 [0].
[0] https://tox.readthedocs.io/en/latest/config.html#conf-ignore_basepython_conflict
Change-Id: I9731a9d99597f14b20e3ab7067ca5a060ec13835
-Switch functional job to run under python3
-Create a functional job to run under python2
-Create a tempest job to run under python2
-Create tox env to run functional tests under python3
-Validate if `USE_PYTHON3` is set to `True` to call
the correct env for tests
-Remove hardcoded path for client when running functional tests
- Update tests failures to work for python2 and python3
Change-Id: I55abc999f6f397b171d05fd9e9b39d833ca95e55
To move ironicclient legacy jobs to zuulv3 the the following changes
were necessary:
- Change `tox.ini` to pass envrioment variables
- Clean `post_test_hook.sh` to avoid legacy variables (`$USER` and
`$BASE`), removing `generate_testr_results` function since we only
get `testrepository.subunit` in logs and the results of the tests
are present in job-output file.
- Convert `post_test_hook.sh` and `run_functional.sh` into
`playbooks/functional/run.yaml` to run after the setup.
Change-Id: I6a5b3f82c238083b66bdf6f379092260d367d82d
The commands used by constraints need at least tox 2.0. Update to
reflect reality, which should help with local running of constraints
targets.
Change-Id: I9e985c4942ad3843b1c0af63d5504c690c836b26
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I77dfc7cc757befdc988016f5f90e4dddada5cc69
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
According to Openstack summit session [1] stestr is
maintained project to which all Openstack projects
should migrate.
Let's switch it then.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: Idf7736fb455d0a13da5a8b6140f5eaa7fa44cb99
Signed-off-by: Charles Short <zulcss@gmail.com>
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
Change-Id: Id15b514bb2b796f928040dc4f767df6627c10e87
Depends-On: https://review.openstack.org/555034
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Curly quotes usually input from Chinese input method.
When read from english context, it makes some confusion.
Change-Id: I37f496630161991cd568e22dd7f54319c4f4f72d
We do not need tox_install.sh, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/tox_install.sh file.
This follows https://review.openstack.org/#/c/508061 to remove
tools/tox_install.sh.
Change-Id: I53af44978840c5b222e421dae6963705c373765d
os-testr 1.0.0 now uses stestr as underlying test runner,
so we should re-configure our testing setup accordingly.
Change-Id: I0a8f23cf2bd934c288daf1a9fa8b672768641163
Enable the following off-by-default checks:
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
* [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in
mock.patch/mock.patch.object calls
Fix code that failed [H205] and [H210]
Change-Id: I7a553e7d40e328f37757fb504a098776cb9bf97c
Newer operating systems, like Fedora 26, ship with Python 3.6 now. So
that they can do a Python 3 test, add 'py36' to the default envlist.
Change-Id: I9c1a6be8e5441e398a265b34aa7378ba8a7d7c0b
Update envs list in tox.ini: py33, py34 are not run on CI anymore.
Make documentation consistent with actual settings in tox.ini.
Change-Id: I7e6ad8acf01a54043f2a2b741c0f1b3376c936d0
Use simple ASCII apostrophe instead of UTF right single quotation mark.
Terminal with SSH to remote Devstack does not display UTF correctly.
Change-Id: Id447cdbf11d19c0c2671a42fd99f42afa68d5aef
According to OpenStack guidelines[1], importing more than
one module per line is allowed if it's function from i18n module.
[1] http://docs.openstack.org/developer/hacking/#imports
Change-Id: I10e90e8f6a4a3f9c161bbaffb030d3fbc9f8499b
Use hacking 0.12.0
Use the new checks that are available:
[H106] Don’t put vim configuration in source files.
[H203] Use assertIs(Not)None to check for None.
[H904] Delay string interpolations at logging calls.
No changes were needed to the code to pass the new checks.
Change-Id: I348a9ef60449fc3d5981013f0be3bfd66d503f6e
This patch is based on the Ironic commit
3aac5a199276a0fc713b9abd3593597d4c677320
This should reduce the number of times you need to completely delete
your tox dir because you have stale pyc files around.
Change-Id: I09a5e5f676de800dac8198957ce742b994bc5e77
This configures tox to use upper-constraints for everything, except
environments used for post jobs (as constraints aren't supported there
yet).
Change-Id: I6f3fb3fba567401c1da0196de30e142f7ca11eb4
Previously the coverage target ended up deleting the coverage data when
the `coverage combine` command ran. This then caused the `coverage html`
command to fail due to lack of data to report on.
Thankfully the fix is simple because pbr is actually handlign all of
this for us behind the scenes. All we need to do is run with the
--coverage flag and make sure the .coveragerc reflects the desired
inclusions and ommisions.
Change-Id: Ide6c7639a19d961e4af27c2c59b036395e2af3ef
Now that there is a passing gate job, we can claim support for
Python 3.5 in the classifier. This patch also adds the convenience
py35 venv.
Change-Id: I167ed334608e45544d0f64a495d95a515d8ade98
Zuul