Update hacking for Python3

The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Fix problems found.

Change-Id: I3dfc16a044db1eaffae909db5aa11496d4294a89

karborclient/tests/unit/test_shell.py

@@ -133,9 +133,9 @@ class ShellCommandTest(ShellTest):
 
     def test_help(self):
         required = [
-            '.*?^usage: karbor',
-            '.*?^\s+plan-create\s+Creates a plan.',
-            '.*?^See "karbor help COMMAND" for help on a specific command',
+            r'.*?^usage: karbor',
+            r'.*?^\s+plan-create\s+Creates a plan.',
+            r'.*?^See "karbor help COMMAND" for help on a specific command',
         ]
         stdout, stderr = self.shell('help')
         for r in required:
@@ -144,8 +144,8 @@ class ShellCommandTest(ShellTest):
 
     def test_help_on_subcommand(self):
         required = [
-            '.*?^usage: karbor plan-create',
-            '.*?^Creates a plan.',
+            r'.*?^usage: karbor plan-create',
+            r'.*?^Creates a plan.',
         ]
         stdout, stderr = self.shell('help plan-create')
         for r in required:
@@ -154,9 +154,9 @@ class ShellCommandTest(ShellTest):
 
     def test_help_no_options(self):
         required = [
-            '.*?^usage: karbor',
-            '.*?^\s+plan-create\s+Creates a plan',
-            '.*?^See "karbor help COMMAND" for help on a specific command',
+            r'.*?^usage: karbor',
+            r'.*?^\s+plan-create\s+Creates a plan',
+            r'.*?^See "karbor help COMMAND" for help on a specific command',
         ]
         stdout, stderr = self.shell('')
         for r in required:

karborclient/v1/shell.py

@@ -195,7 +195,7 @@ def do_plan_update(cs, args):
     if args.name is not None:
         data['name'] = args.name
     if args.description is not None:
-            data['description'] = args.description
+        data['description'] = args.description
     if args.resources is not None:
         plan_resources = arg_utils.extract_resources(args)
         data['resources'] = plan_resources

test-requirements.txt

@@ -2,7 +2,7 @@
 # of appearance. Changing the order has an impact on the overall integration
 # process, which may cause wedges in the gate later.
 
-hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0
+hacking>=3.0,<3.1.0 # Apache-2.0
 
 coverage!=4.4,>=4.0 # Apache-2.0
 python-subunit>=1.0.0 # Apache-2.0/BSD

tox.ini

@@ -43,7 +43,7 @@ commands = oslo_debug_helper -t karborclient/tests {posargs}
 [flake8]
 
 show-source = True
-ignore =
+ignore = W504
 builtins = _
 exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,tools