From 0e659c050e749a94f47adde798947ce02da55cb7 Mon Sep 17 00:00:00 2001 From: David Stanek Date: Mon, 19 May 2014 20:04:00 +0000 Subject: [PATCH] Fixes an erroneous type check in a test The latest version of requests changes the type of a Response's history. See https://github.com/kennethreitz/requests/commit/b8128d6 Closes-Bug: #1321042 Change-Id: Iba9fa20d22d878a4298a35e270338ee442031796 --- keystoneclient/session.py | 4 ---- keystoneclient/tests/test_session.py | 1 - 2 files changed, 5 deletions(-) diff --git a/keystoneclient/session.py b/keystoneclient/session.py index 4a43a1835..7e5010c96 100644 --- a/keystoneclient/session.py +++ b/keystoneclient/session.py @@ -256,10 +256,6 @@ class Session(object): resp = self._send_request(url, method, redirect, **kwargs) - # NOTE(jamielennox): we create a tuple here to be the same as what is - # returned by the requests library. - resp.history = tuple(resp.history) - if raise_exc and resp.status_code >= 400: _logger.debug('Request returned failure status: %s', resp.status_code) diff --git a/keystoneclient/tests/test_session.py b/keystoneclient/tests/test_session.py index 869d4396b..64e573681 100644 --- a/keystoneclient/tests/test_session.py +++ b/keystoneclient/tests/test_session.py @@ -235,7 +235,6 @@ class RedirectTests(utils.TestCase): ses_resp = session.get(self.REDIRECT_CHAIN[0]) - self.assertEqual(type(req_resp.history), type(ses_resp.history)) self.assertEqual(len(req_resp.history), len(ses_resp.history)) for r, s in zip(req_resp.history, ses_resp.history):