openstack
/
python-keystoneclient
Code Issues Proposed changes

Fix for the deprecated library function 

os.popen() is deprecated since version 2.6. Resolved with use of
subprocess module.

Change-Id: I53c21d6e8a9d23646c236ae33d652f1aefc20153
Closes-Bug: #1529836
This commit is contained in:
Yatin Kumbhare 2016-01-05 12:30:29 +05:30
parent 2df8593faa
commit 13ade585c6
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/conf.py
View File

@ -15,6 +15,7 @@
from __future__ import unicode_literals
import os
import subprocess
import sys
import pbr.version
@ -151,8 +152,10 @@ man_pages = [
# If not '', a 'Last updated on:' timestamp is inserted at every page bottom,
# using the given strftime format.
git_cmd = "git log --pretty=format:'%ad, commit %h' --date=local -n1"
html_last_updated_fmt = os.popen(git_cmd).read()
git_cmd = ["git", "log", "--pretty=format:'%ad, commit %h'", "--date=local",
"-n1"]
html_last_updated_fmt = subprocess.Popen(git_cmd,
stdout=subprocess.PIPE).communicate()[0]
# If true, SmartyPants will be used to convert quotes and dashes to
# typographically correct entities.