From 6b72fb626af57a85d1b3411d0c7e8b3d8fdc33b2 Mon Sep 17 00:00:00 2001 From: "Kevin L. Mitchell" Date: Mon, 3 Dec 2012 14:24:38 -0600 Subject: [PATCH] Don't try to split a list of memcache servers The memcache_servers configuration option is declared as a ListOpt, but when used in AuthProtocol.__init__(), we treat it as a string to be split on ',', which is wrong. Remove the .split(). No test is added because the memcache package may not be installed, and I cannot see an easy method to only test this clause if it is available. Fixes bug 1086125. Change-Id: Ifb0a18017d2407b3ccb2188b1a704c26997ba594 --- keystoneclient/middleware/auth_token.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keystoneclient/middleware/auth_token.py b/keystoneclient/middleware/auth_token.py index b6c2be0ce..0267812b9 100644 --- a/keystoneclient/middleware/auth_token.py +++ b/keystoneclient/middleware/auth_token.py @@ -268,7 +268,7 @@ class AuthProtocol(object): import memcache import iso8601 LOG.info('Using memcache for caching token') - self._cache = memcache.Client(memcache_servers.split(',')) + self._cache = memcache.Client(memcache_servers) self._iso8601 = iso8601 except ImportError as e: LOG.warn('disabled caching due to missing libraries %s', e)