openstack/python-keystoneclient
Code Issues Proposed changes

Fix unit tests broken by requests-mock

Browse Source 
Now requests-mock records request url in log[1], so it is
invalid to check that the logger output does NOT contain
request url.

Also, fix url passed to request mock as now it requires
complete url is passed

[1] https://github.com/jamielennox/requests-mock/pull/93

Change-Id: I4bab30a6705b7cab6b5a569dd61c442263e39995
This commit is contained in:
Takashi Kajinami
2019-09-06 15:03:38 +09:00
parent f7e75f43d8
commit 27d4376ea5
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneclient/tests/unit/test_session.py
View File

@@ -828,7 +828,6 @@ class SessionAuthTests(utils.TestCase):
self.assertIn(list(response.keys())[0], output) self.assertIn(list(response.keys())[0], output)
self.assertIn(list(response.values())[0], output) self.assertIn(list(response.values())[0], output)
self.assertNotIn(self.TEST_URL, self.logger.output)
self.assertNotIn(list(response.keys())[0], self.logger.output) self.assertNotIn(list(response.keys())[0], self.logger.output)
self.assertNotIn(list(response.values())[0], self.logger.output) self.assertNotIn(list(response.values())[0], self.logger.output)
@@ -1026,7 +1025,6 @@ class AdapterTest(utils.TestCase):
self.assertIn(list(response.keys())[0], output) self.assertIn(list(response.keys())[0], output)
self.assertIn(list(response.values())[0], output) self.assertIn(list(response.values())[0], output)
self.assertNotIn(self.TEST_URL, self.logger.output)
self.assertNotIn(list(response.keys())[0], self.logger.output) self.assertNotIn(list(response.keys())[0], self.logger.output)
self.assertNotIn(list(response.values())[0], self.logger.output) self.assertNotIn(list(response.values())[0], self.logger.output)

2
keystoneclient/tests/unit/v3/test_role_assignments.py
View File

@@ -265,7 +265,7 @@ class RoleAssignmentsTests(utils.ClientTestCase, utils.CrudTests):
ref_list = self.TEST_ALL_RESPONSE_LIST ref_list = self.TEST_ALL_RESPONSE_LIST
self.stub_entity('GET', self.stub_entity('GET',
[self.collection_key, [self.collection_key,
'?include_names'], '?include_names=True'],
entity=ref_list) entity=ref_list)
returned_list = self.manager.list(include_names=True) returned_list = self.manager.list(include_names=True)