openstack/python-keystoneclient
Code Issues Proposed changes

Update hacking to 0.9.x

Browse Source 
Address some issues that came up because of hacking upgrade.
But ignoring H904 since the slashes are valid, as they are in
comments, not code.

Change-Id: Ie8a94fc71632e4130c2ec663a5c6d3f2042f8263
Closes-Bug: #1328469
This commit is contained in:
Steve Martinelli
2014-09-21 02:44:37 -04:00
parent 026b6201bf
commit 394d202a6a
5 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneclient/httpclient.py
View File

@@ -20,8 +20,8 @@ OpenStack Client interface. Handles the REST calls and responses.
""" """
import logging import logging
import pkg_resources
import pkg_resources
import requests import requests
from six.moves.urllib import parse as urlparse from six.moves.urllib import parse as urlparse

2
keystoneclient/tests/test_auth_token_middleware.py
View File

@@ -672,7 +672,7 @@ class CommonAuthTokenMiddlewareTest(object):
self.middleware(req.environ, self.start_fake_response) self.middleware(req.environ, self.start_fake_response)
self.assertEqual(200, self.response_status) self.assertEqual(200, self.response_status)
# This time use the PKI(Z) token # This time use the PKI(Z) token
req.headers['X-Auth-Token'] = token req.headers['X-Auth-Token'] = token
self.middleware(req.environ, self.start_fake_response) self.middleware(req.environ, self.start_fake_response)

7
keystoneclient/tests/v2_0/test_shell.py
View File

@@ -145,10 +145,9 @@ class ShellTests(utils.TestCase):
self.run_command('user-update --name new-user1' self.run_command('user-update --name new-user1'
' --email user@email.com --enabled true 1') ' --email user@email.com --enabled true 1')
self.assert_called('PUT', '/users/1') self.assert_called('PUT', '/users/1')
self.assertRequestBodyIs(json={'user': {'id': '1', body = {'user': {'id': '1', 'email': 'user@email.com',
'email': 'user@email.com', 'enabled': True, 'name': 'new-user1'}}
'enabled': True, self.assertRequestBodyIs(json=body)
'name': 'new-user1'}})
required = 'User not updated, no arguments present.' required = 'User not updated, no arguments present.'
out = self.run_command('user-update 1') out = self.run_command('user-update 1')

2
test-requirements.txt
View File

@@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
hacking>=0.8.0,<0.9 hacking>=0.9.2,<0.10
coverage>=3.6 coverage>=3.6
discover discover

3
tox.ini
View File

@@ -38,7 +38,8 @@ commands =
# H803 Commit message should not end with a period (do not remove per list discussion) # H803 Commit message should not end with a period (do not remove per list discussion)
# H405: multi line docstring summary not separated with an empty line # H405: multi line docstring summary not separated with an empty line
# E122: continuation line missing indentation or outdented # E122: continuation line missing indentation or outdented
ignore = F821,H304,H803,H405,E122 # H904: Wrap long lines in parentheses instead of a backslash
ignore = F821,H304,H803,H405,E122,H904
show-source = True show-source = True
exclude = .venv,.tox,dist,doc,*egg,build,*openstack/common* exclude = .venv,.tox,dist,doc,*egg,build,*openstack/common*