From 3b766c51438396a0ab0032de309c9d56e275e0cb Mon Sep 17 00:00:00 2001 From: Brant Knudson Date: Mon, 27 Oct 2014 16:20:44 -0500 Subject: [PATCH] Correct use of noqa The use of "#flake8: noqa" disables hacking checks for the entire file. Switched to use of "# noqa" and fixed hacking problems. Change-Id: I18785fb18bdce88e61e2451960e55aed0863c285 --- keystoneclient/exceptions.py | 10 +++++----- keystoneclient/v2_0/__init__.py | 3 +-- keystoneclient/v3/__init__.py | 4 ++-- keystoneclient/v3/contrib/federation/__init__.py | 2 +- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/keystoneclient/exceptions.py b/keystoneclient/exceptions.py index 5ad84c07c..0370dd6e7 100644 --- a/keystoneclient/exceptions.py +++ b/keystoneclient/exceptions.py @@ -16,8 +16,7 @@ Exception definitions. """ -#flake8: noqa -from keystoneclient.openstack.common.apiclient.exceptions import * +from keystoneclient.openstack.common.apiclient.exceptions import * # noqa # NOTE(akurilin): This alias should be left here to support backwards # compatibility until we are sure that usage of these exceptions in @@ -29,7 +28,7 @@ HTTPError = HttpError class CertificateConfigError(Exception): - """Error reading the certificate""" + """Error reading the certificate.""" def __init__(self, output): self.output = output msg = 'Unable to load certificate.' @@ -37,7 +36,7 @@ class CertificateConfigError(Exception): class CMSError(Exception): - """Error reading the certificate""" + """Error reading the certificate.""" def __init__(self, output): self.output = output msg = 'Unable to sign or verify data.' @@ -71,7 +70,8 @@ class MissingAuthPlugin(ClientException): class NoMatchingPlugin(ClientException): """There were no auth plugins that could be created from the parameters - provided.""" + provided. + """ class InvalidResponse(ClientException): diff --git a/keystoneclient/v2_0/__init__.py b/keystoneclient/v2_0/__init__.py index f99be3bb6..30407e0c6 100644 --- a/keystoneclient/v2_0/__init__.py +++ b/keystoneclient/v2_0/__init__.py @@ -1,5 +1,4 @@ -# flake8: noqa -from keystoneclient.v2_0.client import Client +from keystoneclient.v2_0.client import Client # noqa __all__ = [ diff --git a/keystoneclient/v3/__init__.py b/keystoneclient/v3/__init__.py index 4685f9f69..56b26d3b4 100644 --- a/keystoneclient/v3/__init__.py +++ b/keystoneclient/v3/__init__.py @@ -1,5 +1,5 @@ -# flake8: noqa -from keystoneclient.v3.client import Client + +from keystoneclient.v3.client import Client # noqa __all__ = [ diff --git a/keystoneclient/v3/contrib/federation/__init__.py b/keystoneclient/v3/contrib/federation/__init__.py index 8d31b75e3..ee9bcef98 100644 --- a/keystoneclient/v3/contrib/federation/__init__.py +++ b/keystoneclient/v3/contrib/federation/__init__.py @@ -10,4 +10,4 @@ # License for the specific language governing permissions and limitations # under the License. -from keystoneclient.v3.contrib.federation.core import * # flake8: noqa +from keystoneclient.v3.contrib.federation.core import * # noqa