From 4766d168ba4c86eef8a6bd04eeb0401ab2e33cd5 Mon Sep 17 00:00:00 2001 From: liuqing Date: Tue, 1 Jul 2014 16:42:24 +0800 Subject: [PATCH] Use immutable arg rather mutable arg Passing mutable objects as default args is a known Python pitfall. We'd better avoid this. This commit changes mutable default args with None, then use 'arg = arg or []'. Change-Id: I52a37bbc129fab40a99c919a837147d663941dce --- keystoneclient/tests/fakes.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/keystoneclient/tests/fakes.py b/keystoneclient/tests/fakes.py index d04ad8c50..70abcc4f0 100644 --- a/keystoneclient/tests/fakes.py +++ b/keystoneclient/tests/fakes.py @@ -21,7 +21,9 @@ places where actual behavior differs from the spec. from keystoneclient import access -def assert_has_keys(dict, required=[], optional=[]): +def assert_has_keys(dict, required=None, optional=None): + required = required or [] + optional = optional or [] keys = dict.keys() for k in required: try: