From 54f19dc407aac463ea2d70d6b47339e31cc38317 Mon Sep 17 00:00:00 2001 From: Ghanshyam Mann Date: Tue, 12 May 2020 18:27:39 -0500 Subject: [PATCH] Fix hacking min version to 3.0.1 flake8 new release 3.8.0 added new checks and gate pep8 job start failing. hacking 3.0.1 fix the pinning of flake8 to avoid bringing in a new version with new checks. Though it is fixed in latest hacking but 2.0 and 3.0 has cap for flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also break the pep8 job if new check are added. To avoid similar gate break in future, we need to bump the hacking min version. Also removing the hacking and other related dep from lower-constraints file as theose are blacklisted requirements and does not need to be present there. - http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html Change-Id: I636e12ccfb0ad12bfe7f8095cbd196d36902f645 --- lower-constraints.txt | 4 ---- test-requirements.txt | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lower-constraints.txt b/lower-constraints.txt index 885c61526..38df4fa4e 100644 --- a/lower-constraints.txt +++ b/lower-constraints.txt @@ -12,11 +12,9 @@ extras==1.0.0 fasteners==0.7.0 fixtures==3.0.0 flake8-docstrings==0.2.1.post1 -flake8==2.2.4 future==0.16.0 gitdb==0.6.4 GitPython==1.0.1 -hacking==0.10.0 idna==2.6 iso8601==0.1.11 jsonschema==2.6.0 @@ -45,11 +43,9 @@ oslotest==3.2.0 paramiko==2.0.0 pbr==2.0.0 pep257==0.7.0 -pep8==1.5.7 prettytable==0.7.2 pyasn1==0.1.8 pycparser==2.18 -pyflakes==0.8.1 pyinotify==0.9.6 pyparsing==2.1.0 pyperclip==1.5.27 diff --git a/test-requirements.txt b/test-requirements.txt index d9e19726a..4f53bfd8e 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -2,7 +2,7 @@ # of appearance. Changing the order has an impact on the overall integration # process, which may cause wedges in the gate later. -hacking>=3.0,<3.1.0 # Apache-2.0 +hacking>=3.0.1,<3.1.0 # Apache-2.0 flake8-docstrings==0.2.1.post1 # MIT coverage!=4.4,>=4.0 # Apache-2.0