openstack/python-keystoneclient
Code Issues Proposed changes

Merge "set close_fds=True in Popen"

Browse Source
This commit is contained in:
Jenkins
2014-10-23 17:12:00 +00:00
committed by Gerrit Code Review
parent 7eb033ad1a f00755f04a
commit 6d85d182a2
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
keystoneclient/common/cms.py
View File

@@ -148,7 +148,8 @@ def cms_verify(formatted, signing_cert_file_name, ca_file_name,
'-nocerts', '-noattr'], '-nocerts', '-noattr'],
stdin=subprocess.PIPE, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.PIPE) stderr=subprocess.PIPE,
close_fds=True)
output, err, retcode = _process_communicate_handle_oserror( output, err, retcode = _process_communicate_handle_oserror(
process, data, (signing_cert_file_name, ca_file_name)) process, data, (signing_cert_file_name, ca_file_name))
@@ -336,7 +337,8 @@ def cms_sign_data(data_to_sign, signing_cert_file_name, signing_key_file_name,
'-md', 'sha256', ], '-md', 'sha256', ],
stdin=subprocess.PIPE, stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.PIPE) stderr=subprocess.PIPE,
close_fds=True)
output, err, retcode = _process_communicate_handle_oserror( output, err, retcode = _process_communicate_handle_oserror(
process, data, (signing_cert_file_name, signing_key_file_name)) process, data, (signing_cert_file_name, signing_key_file_name))