From 992e371e4db940ea2805240d622865e2250365ae Mon Sep 17 00:00:00 2001 From: "ChangBo Guo(gcb)" Date: Fri, 16 May 2014 10:55:23 +0800 Subject: [PATCH] Don't use mock non-exist method assert_called_once There isn't method assert_called_once of mock class and hence does not really check anything. Let's use assertEqual(1, mock.call_count) to check. Change-Id: I2bdf62b775badc0adbe2c6f55bcc65cd13ac2d60 --- keystoneclient/tests/test_keyring.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/keystoneclient/tests/test_keyring.py b/keystoneclient/tests/test_keyring.py index 2814c4e28..24f4bb5fe 100644 --- a/keystoneclient/tests/test_keyring.py +++ b/keystoneclient/tests/test_keyring.py @@ -96,7 +96,7 @@ class KeyringTest(utils.TestCase): self.assertTrue(cl.authenticate()) - meth.assert_called_once() + self.assertEqual(1, meth.call_count) # make sure that we never touched the keyring self.assertFalse(self.memory_keyring.get_password_called) @@ -134,7 +134,7 @@ class KeyringTest(utils.TestCase): self.assertTrue(cl.authenticate()) - meth.assert_called_once() + self.assertEqual(1, meth.call_count) # check that a value was returned from the keyring self.assertTrue(self.memory_keyring.fetched) @@ -172,7 +172,7 @@ class KeyringTest(utils.TestCase): self.assertTrue(cl.authenticate()) - meth.assert_called_once() + self.assertEqual(1, meth.call_count) # we checked the keyring, but we didn't find anything self.assertTrue(self.memory_keyring.get_password_called)