openstack/python-keystoneclient
Code Issues Proposed changes

Adapter version is a tuple

Browse Source 
The docstring for Adapter says that the version is a tuple like
(3,0), but the HttpClient was passing a string like "v3".

Closes-Bug: 1450272
Change-Id: I74b009d68f5601bda3ae92b3c8de1ecef00d8316
This commit is contained in:
Brant Knudson
2015-04-29 17:36:43 -05:00
parent fc7fb0d76b
commit 99e3b48a21
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
keystoneclient/httpclient.py
View File

@@ -51,6 +51,7 @@ if not hasattr(urlparse, 'parse_qsl'):
urlparse.parse_qsl = cgi.parse_qsl urlparse.parse_qsl = cgi.parse_qsl
from keystoneclient import _discover
from keystoneclient import access from keystoneclient import access
from keystoneclient import adapter from keystoneclient import adapter
from keystoneclient.auth import base from keystoneclient.auth import base
@@ -323,13 +324,16 @@ class HTTPClient(baseclient.Client, base.BaseAuthPlugin):
# NOTE(jamielennox): unfortunately we can't just use **kwargs here as # NOTE(jamielennox): unfortunately we can't just use **kwargs here as
# it would incompatibly limit the kwargs that can be passed to __init__ # it would incompatibly limit the kwargs that can be passed to __init__
# try and keep this list in sync with adapter.Adapter.__init__ # try and keep this list in sync with adapter.Adapter.__init__
version = (
_discover.normalize_version_number(self.version) if self.version
else None)
self._adapter = _KeystoneAdapter(session, self._adapter = _KeystoneAdapter(session,
service_type='identity', service_type='identity',
service_name=service_name, service_name=service_name,
interface=interface, interface=interface,
region_name=region_name, region_name=region_name,
endpoint_override=endpoint_override, endpoint_override=endpoint_override,
version=self.version, version=version,
auth=auth, auth=auth,
user_agent=user_agent, user_agent=user_agent,
connect_retries=connect_retries) connect_retries=connect_retries)

2
keystoneclient/tests/unit/v2_0/test_client.py
View File

@@ -181,4 +181,4 @@ class KeystoneClientTest(utils.TestCase):
self.assertEqual(v, getattr(cl._adapter, k)) self.assertEqual(v, getattr(cl._adapter, k))
self.assertEqual('identity', cl._adapter.service_type) self.assertEqual('identity', cl._adapter.service_type)
self.assertEqual('v2.0', cl._adapter.version) self.assertEqual((2, 0), cl._adapter.version)

2
keystoneclient/tests/unit/v3/test_client.py
View File

@@ -227,4 +227,4 @@ class KeystoneClientTest(utils.TestCase):
self.assertEqual(v, getattr(cl._adapter, k)) self.assertEqual(v, getattr(cl._adapter, k))
self.assertEqual('identity', cl._adapter.service_type) self.assertEqual('identity', cl._adapter.service_type)
self.assertEqual('v3', cl._adapter.version) self.assertEqual((3, 0), cl._adapter.version)