From a1088d019de61cd84cd02cbb21f82ff4d256f5cc Mon Sep 17 00:00:00 2001 From: Brant Knudson Date: Mon, 27 Oct 2014 17:17:39 -0500 Subject: [PATCH] Cleanup exception logging LOG.exception() already prints the exception, so passing the exception to it isn't useful. Pass a message instead. Change-Id: If5b5be1e275a4688a04ba4ccc582149a3a5f2bd2 --- keystoneclient/generic/client.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/keystoneclient/generic/client.py b/keystoneclient/generic/client.py index 7892739ae..7ca39fbce 100644 --- a/keystoneclient/generic/client.py +++ b/keystoneclient/generic/client.py @@ -19,7 +19,7 @@ from six.moves.urllib import parse as urlparse from keystoneclient import exceptions from keystoneclient import httpclient -from keystoneclient.i18n import _ +from keystoneclient.i18n import _, _LE _logger = logging.getLogger(__name__) @@ -124,8 +124,8 @@ class Client(httpclient.HTTPClient): return self._check_keystone_versions(resp['location']) else: raise exceptions.from_response(resp, "GET", url) - except Exception as e: - _logger.exception(e) + except Exception: + _logger.exception(_LE('Failed to detect available versions.')) def discover_extensions(self, url=None): """Discover Keystone extensions supported. @@ -168,8 +168,8 @@ class Client(httpclient.HTTPClient): else: raise exceptions.from_response( resp, "GET", "%sextensions" % url) - except Exception as e: - _logger.exception(e) + except Exception: + _logger.exception(_LE('Failed to check keystone extensions.')) @staticmethod def _get_version_info(version, root_url):