openstack/python-keystoneclient
Code Issues Proposed changes

Log cms_verify issues as warnings (not errors).

Browse Source 
In general we probably do want to log these types of errors... but
not as ERRORS. I think log Warning messages are probably more
appropriate here since it would be possible to hit this when
expired certs are refreshed...

Fixes LP Bug #1190230.

Change-Id: I0383f7e490ddcdfb31a62cd3760102152a8d16d9
This commit is contained in:
Dan Prince
2013-06-12 09:21:10 -04:00
parent 76daaffd87
commit a4af27a705
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneclient/common/cms.py
View File

@@ -41,7 +41,7 @@ def cms_verify(formatted, signing_cert_file_name, ca_file_name):
output, err = process.communicate(formatted) output, err = process.communicate(formatted)
retcode = process.poll() retcode = process.poll()
if retcode: if retcode:
LOG.error('Verify error: %s' % err) LOG.warning('Verify error: %s' % err)
# NOTE(dmllr): Python 2.6 compatibility: # NOTE(dmllr): Python 2.6 compatibility:
# CalledProcessError did not have output keyword argument # CalledProcessError did not have output keyword argument
e = subprocess.CalledProcessError(retcode, "openssl") e = subprocess.CalledProcessError(retcode, "openssl")