openstack/python-keystoneclient
Code Issues Proposed changes

Mark auth plugin options as secret

Browse Source 
By marking the options as secret they don't get printed out in things
like the debug log when loading the application.

Change-Id: Iadab479a896bc4b1682ee8d207cc50a01dca8255
This commit is contained in:
Jamie Lennox 2014-08-07 13:40:05 +10:00
parent 4b10d11c1a
commit a8cca7e889
3 changed files with 9 additions and 5 deletions
keystoneclient/auth
identity
v2.pyv3.py
token_endpoint.py

4
keystoneclient/auth/identity/v2.py

@ -121,7 +121,7 @@ class Password(Auth):
dest='username',
deprecated_name='username',
help='Username to login with'),
cfg.StrOpt('password', help='Password to use'),
cfg.StrOpt('password', secret=True, help='Password to use'),
])
return options
@ -148,7 +148,7 @@ class Token(Auth):
options = super(Token, cls).get_options()
options.extend([
cfg.StrOpt('token', help='Token'),
cfg.StrOpt('token', secret=True, help='Token'),
])
return options

6
keystoneclient/auth/identity/v3.py

@ -249,7 +249,7 @@ class Password(AuthConstructor):
deprecated_name='username'),
cfg.StrOpt('user-domain-id', help="User's domain id"),
cfg.StrOpt('user-domain-name', help="User's domain name"),
cfg.StrOpt('password', help="User's password"),
cfg.StrOpt('password', secret=True, help="User's password"),
])
return options
@ -282,7 +282,9 @@ class Token(AuthConstructor):
options = super(Token, cls).get_options()
options.extend([
cfg.StrOpt('token', help='Token to authenticate with'),
cfg.StrOpt('token',
secret=True,
help='Token to authenticate with'),
])
return options

4
keystoneclient/auth/token_endpoint.py

@ -44,7 +44,9 @@ class Token(base.BaseAuthPlugin):
options.extend([
cfg.StrOpt('endpoint',
help='The endpoint that will always be used'),
cfg.StrOpt('token', help='The token that will always be used'),
cfg.StrOpt('token',
secret=True,
help='The token that will always be used'),
])
return options