From a9ebec4fbda82c51bad5eae4bcec3356f7af7f1d Mon Sep 17 00:00:00 2001 From: chenaidong1 Date: Thu, 8 Dec 2016 14:56:39 +0800 Subject: [PATCH] Use assertIsNone(...) instead of assertEqual(None, ...) Refer to:http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises [H203] Use assertIs(Not)None to check for None (off by default) Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(...) is preferred over assertEqual(None, ...) and assertIs(None, ...) Change-Id: I4e60f3f7f3557080669b98cb48627acc40a72606 --- keystoneclient/tests/unit/v2_0/test_client.py | 2 +- keystoneclient/tests/unit/v3/test_client.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/keystoneclient/tests/unit/v2_0/test_client.py b/keystoneclient/tests/unit/v2_0/test_client.py index 90b645052..fc9bf140e 100644 --- a/keystoneclient/tests/unit/v2_0/test_client.py +++ b/keystoneclient/tests/unit/v2_0/test_client.py @@ -218,4 +218,4 @@ class KeystoneClientTest(utils.TestCase): # authenticated sess = auth_session.Session() cl = client.Client(session=sess) - self.assertEqual(None, cl.service_catalog) + self.assertIsNone(cl.service_catalog) diff --git a/keystoneclient/tests/unit/v3/test_client.py b/keystoneclient/tests/unit/v3/test_client.py index 42004ff10..29a281831 100644 --- a/keystoneclient/tests/unit/v3/test_client.py +++ b/keystoneclient/tests/unit/v3/test_client.py @@ -268,4 +268,4 @@ class KeystoneClientTest(utils.TestCase): # authenticated sess = auth_session.Session() cl = client.Client(session=sess) - self.assertEqual(None, cl.service_catalog) + self.assertIsNone(cl.service_catalog)