openstack/python-keystoneclient
Code Issues Proposed changes

Use assertIn where appropriate

Browse Source 
Change-Id: I641f1d840f276b65ae1449da3705a248e4592485
This commit is contained in:
Dirk Mueller
2013-11-28 22:51:29 +01:00
parent 30ab23854c
commit b51cae6066
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
keystoneclient/tests/test_auth_token_middleware.py
View File

@@ -362,7 +362,7 @@ class DiabloAuthTokenMiddlewareTest(BaseAuthTokenMiddlewareTest):
req.headers['X-Auth-Token'] = self.token_id req.headers['X-Auth-Token'] = self.token_id
self.middleware(req.environ, self.start_fake_response) self.middleware(req.environ, self.start_fake_response)
self.assertEqual(self.response_status, 200) self.assertEqual(self.response_status, 200)
self.assertTrue('keystone.token_info' in req.environ) self.assertIn('keystone.token_info', req.environ)
class NoMemcacheAuthToken(BaseAuthTokenMiddlewareTest): class NoMemcacheAuthToken(BaseAuthTokenMiddlewareTest):
@@ -422,7 +422,7 @@ class CommonAuthTokenMiddlewareTest(object):
else: else:
self.assertNotIn('X-Service-Catalog', req.headers) self.assertNotIn('X-Service-Catalog', req.headers)
self.assertEqual(body, ['SUCCESS']) self.assertEqual(body, ['SUCCESS'])
self.assertTrue('keystone.token_info' in req.environ) self.assertIn('keystone.token_info', req.environ)
def test_valid_uuid_request(self): def test_valid_uuid_request(self):
self.assert_valid_request_200(self.token_dict['uuid_token_default']) self.assert_valid_request_200(self.token_dict['uuid_token_default'])
@@ -1043,7 +1043,7 @@ class v2AuthTokenMiddlewareTest(BaseAuthTokenMiddlewareTest,
body = self.middleware(req.environ, self.start_fake_response) body = self.middleware(req.environ, self.start_fake_response)
self.assertEqual(self.response_status, 200) self.assertEqual(self.response_status, 200)
self.assertEqual(body, ['SUCCESS']) self.assertEqual(body, ['SUCCESS'])
self.assertTrue('keystone.token_info' in req.environ) self.assertIn('keystone.token_info', req.environ)
def assert_valid_last_url(self, token_id): def assert_valid_last_url(self, token_id):
self.assertLastPath("/testadmin/v2.0/tokens/%s" % token_id) self.assertLastPath("/testadmin/v2.0/tokens/%s" % token_id)