openstack/python-keystoneclient
Code Issues Proposed changes

Fix misused assertTrue in unit tests

Browse Source 
Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Fixes bug #1226374

Change-Id: I678b2e7fcc522c8776c7fc0a554c1fc229ab781e
This commit is contained in:
Chang Bo Guo
2013-09-17 08:41:51 -07:00
parent 5588abdf8a
commit baa949017a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
keystoneclient/tests/v2_0/test_ec2.py
View File

@@ -98,9 +98,9 @@ class EC2Tests(utils.TestCase):
'OS-EC2'], json=resp_body) 'OS-EC2'], json=resp_body)
creds = self.client.ec2.list(user_id) creds = self.client.ec2.list(user_id)
self.assertTrue(len(creds), 2) self.assertEqual(len(creds), 2)
cred = creds[0] cred = creds[0]
self.assertTrue(isinstance(cred, ec2.EC2)) self.assertIsInstance(cred, ec2.EC2)
self.assertEqual(cred.tenant_id, tenant_id) self.assertEqual(cred.tenant_id, tenant_id)
self.assertEqual(cred.enabled, True) self.assertEqual(cred.enabled, True)
self.assertEqual(cred.access, 'access') self.assertEqual(cred.access, 'access')