openstack/python-keystoneclient
Code Issues Proposed changes

Fixing D202 and D203 PEP257 violation.

Browse Source 
Currently tox ignores D202 and D203.
D202: No blank lines allowed after function docstring.
D203: 1 blank required before class docstring.
This change removes D202 and D203 ignores in tox and fix violations.

Change-Id: I97ef88c9cfd56774e47f789cbbcf8ccfe85d7737
This commit is contained in:
Navid Pustchi
2016-05-03 18:54:12 +00:00
parent a9adca02db
commit bca112c8ba
35 changed files with 1 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
keystoneclient/auth/base.py
View File

@@ -276,7 +276,6 @@ class BaseAuthPlugin(object):
:param parser: the parser to attach argparse options.
:type parser: argparse.ArgumentParser
"""
# NOTE(jamielennox): ideally oslo_config would be smart enough to
# handle all the Opt manipulation that goes on in this file. However it
# is currently not. Options are handled in as similar a way as
@@ -313,7 +312,6 @@ class BaseAuthPlugin(object):
:returns: An auth plugin, or None if a name is not provided.
:rtype: :py:class:`keystoneclient.auth.BaseAuthPlugin`
"""
def _getter(opt):
return getattr(namespace, 'os_%s' % opt.dest)
@@ -343,7 +341,6 @@ class BaseAuthPlugin(object):
:returns: An authentication Plugin.
:rtype: :py:class:`keystoneclient.auth.BaseAuthPlugin`
"""
def _getter(opt):
return conf[group][opt.dest]
@@ -366,7 +363,6 @@ class BaseAuthPlugin(object):
:returns: An authentication Plugin.
:rtype: :py:class:`keystoneclient.auth.BaseAuthPlugin`
"""
plugin_opts = cls.get_options()
for opt in plugin_opts:

8
keystoneclient/auth/identity/base.py
View File

@@ -73,7 +73,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'username is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -86,7 +85,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'username is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -99,7 +97,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'password is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -112,7 +109,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'password is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -125,7 +121,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'token is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -138,7 +133,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'token is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -151,7 +145,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'trust_id is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)
@@ -164,7 +157,6 @@ class BaseIdentityPlugin(base.BaseAuthPlugin):
It may be removed in the 2.0.0 release.
"""
warnings.warn(
'trust_id is deprecated as of the 1.7.0 release and may be '
'removed in the 2.0.0 release.', DeprecationWarning)