openstack/python-keystoneclient
Code Issues Proposed changes

auth_token test remove unused fake_app parameter

Browse Source 
set_middleware is never called with fake_app, so remove it.

Change-Id: Id4541f77a12a9d43f2761f8d1fd14d633f6944ac
This commit is contained in:
Brant Knudson
2014-04-27 16:59:58 -05:00
parent cb2045e134
commit c00ef0e751
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
keystoneclient/tests/test_auth_token_middleware.py
View File

@@ -275,7 +275,7 @@ class BaseAuthTokenMiddlewareTest(testtools.TestCase):
self.response_status = None self.response_status = None
self.response_headers = None self.response_headers = None
def set_middleware(self, fake_app=None, expected_env=None, conf=None): def set_middleware(self, expected_env=None, conf=None):
"""Configure the class ready to call the auth_token middleware. """Configure the class ready to call the auth_token middleware.
Set up the various fake items needed to run the middleware. Set up the various fake items needed to run the middleware.
@@ -286,14 +286,11 @@ class BaseAuthTokenMiddlewareTest(testtools.TestCase):
if conf: if conf:
self.conf.update(conf) self.conf.update(conf)
if not fake_app:
fake_app = self.fake_app
if expected_env: if expected_env:
self.expected_env.update(expected_env) self.expected_env.update(expected_env)
self.middleware = auth_token.AuthProtocol(fake_app(self.expected_env), self.middleware = auth_token.AuthProtocol(
self.conf) self.fake_app(self.expected_env), self.conf)
self.middleware._iso8601 = iso8601 self.middleware._iso8601 = iso8601
with tempfile.NamedTemporaryFile(dir=self.middleware.signing_dirname, with tempfile.NamedTemporaryFile(dir=self.middleware.signing_dirname,