openstack/python-keystoneclient
Code Issues Proposed changes

Merge "Bump hacking"

Browse Source
This commit is contained in:
Zuul 2024-02-08 16:12:47 +00:00 committed by Gerrit Code Review
commit c66d778f3f
5 changed files with 4 additions and 13 deletions

2
keystoneclient/tests/unit/test_base.py

@ -319,7 +319,7 @@ class ManagerRequestIdTest(utils.TestCase):
delete_mock.assert_called_once_with('/test-url', name='hello') delete_mock.assert_called_once_with('/test-url', name='hello')
self.assertEqual(base_resp.request_ids[0], TEST_REQUEST_ID) self.assertEqual(base_resp.request_ids[0], TEST_REQUEST_ID)
self.assertEqual(base_resp.data, None) self.assertEqual(base_resp.data, None)
self.assertTrue(isinstance(resp, requests.Response)) self.assertIsInstance(resp, requests.Response)
def test_patch(self): def test_patch(self):
body = {"hello": {"hi": 1}} body = {"hello": {"hi": 1}}

2
keystoneclient/tests/unit/v3/utils.py

@ -280,7 +280,7 @@ class CrudTests(object):
return expected_path return expected_path
def test_list_by_id(self, ref=None, **filter_kwargs): def test_list_by_id(self, ref=None, **filter_kwargs):
"""Test ``entities.list(id=x)`` being rewritten as ``GET /v3/entities/x``. """Test ``entities.list(id=x)`` being rewritten as ``GET /v3/entities/x``. # noqa
This tests an edge case of each manager's list() implementation, to This tests an edge case of each manager's list() implementation, to
ensure that it "does the right thing" when users call ``.list()`` ensure that it "does the right thing" when users call ``.list()``

2
keystoneclient/v3/application_credentials.py

@ -137,7 +137,7 @@ class ApplicationCredentialManager(base.CrudManager):
return super(ApplicationCredentialManager, self).list(**kwargs) return super(ApplicationCredentialManager, self).list(**kwargs)
def find(self, user=None, **kwargs): def find(self, user=None, **kwargs):
"""Find an application credential with attributes matching ``**kwargs``. """Find an application credential with attributes matching ``**kwargs``. # noqa
:param string user: User ID :param string user: User ID

5
requirements.txt

@ -1,11 +1,6 @@
# Requirements lower bounds listed here are our best effort to keep them up to # Requirements lower bounds listed here are our best effort to keep them up to
# date but we do not test them so no guarantee of having them all correct. If # date but we do not test them so no guarantee of having them all correct. If
# you find any incorrect lower bounds, let us know or propose a fix. # you find any incorrect lower bounds, let us know or propose a fix.
# The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
pbr!=2.1.0,>=2.0.0 # Apache-2.0 pbr!=2.1.0,>=2.0.0 # Apache-2.0
debtcollector>=1.2.0 # Apache-2.0 debtcollector>=1.2.0 # Apache-2.0

6
test-requirements.txt

@ -1,8 +1,4 @@
# The order of packages is significant, because pip processes them in the order hacking>=6.1.0,<6.2.0 # Apache-2.0
# of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later.
hacking>=3.0.1,<3.1.0 # Apache-2.0
flake8-docstrings==1.7.0 # MIT flake8-docstrings==1.7.0 # MIT
coverage!=4.4,>=4.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0