openstack/python-keystoneclient
Code Issues Proposed changes

Remove endpoint.name attribute from v3 manager (bug 1191152)

Browse Source 
This also provides backwards compatible support for any clients that
were specifying a name by handling it through **kwargs.

Change-Id: I49c542c52e1cdfde5fff1be46d658a805d233320
This commit is contained in:
Dolph Mathews
2013-06-14 15:51:16 -05:00
parent 446379b93f
commit d2702e17c9
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
keystoneclient/v3/endpoints.py
View File

@@ -47,22 +47,23 @@ class EndpointManager(base.CrudManager):
msg = msg % ', '.join(VALID_INTERFACES) msg = msg % ', '.join(VALID_INTERFACES)
raise Exception(msg) raise Exception(msg)
def create(self, service, url, name=None, interface=None, region=None, def create(self, service, url, interface=None, region=None, enabled=True,
enabled=True): **kwargs):
self._validate_interface(interface) self._validate_interface(interface)
return super(EndpointManager, self).create( return super(EndpointManager, self).create(
service_id=base.getid(service), service_id=base.getid(service),
interface=interface, interface=interface,
url=url, url=url,
region=region, region=region,
enabled=enabled) enabled=enabled,
**kwargs)
def get(self, endpoint): def get(self, endpoint):
return super(EndpointManager, self).get( return super(EndpointManager, self).get(
endpoint_id=base.getid(endpoint)) endpoint_id=base.getid(endpoint))
def list(self, service=None, interface=None, region=None, def list(self, service=None, interface=None, region=None, enabled=None,
enabled=None, **kwargs): **kwargs):
"""List endpoints. """List endpoints.
If ``**kwargs`` are provided, then filter endpoints with If ``**kwargs`` are provided, then filter endpoints with
@@ -76,8 +77,8 @@ class EndpointManager(base.CrudManager):
enabled=enabled, enabled=enabled,
**kwargs) **kwargs)
def update(self, endpoint, service=None, url=None, name=None, def update(self, endpoint, service=None, url=None, interface=None,
interface=None, region=None, enabled=None): region=None, enabled=None, **kwargs):
self._validate_interface(interface) self._validate_interface(interface)
return super(EndpointManager, self).update( return super(EndpointManager, self).update(
endpoint_id=base.getid(endpoint), endpoint_id=base.getid(endpoint),
@@ -85,7 +86,8 @@ class EndpointManager(base.CrudManager):
interface=interface, interface=interface,
url=url, url=url,
region=region, region=region,
enabled=enabled) enabled=enabled,
**kwargs)
def delete(self, endpoint): def delete(self, endpoint):
return super(EndpointManager, self).delete( return super(EndpointManager, self).delete(