From 97d51bd8326af52fd197754f24a866a0d28df122 Mon Sep 17 00:00:00 2001 From: Brant Knudson Date: Sun, 11 Jan 2015 12:23:18 -0600 Subject: [PATCH] Correct failures for check H238 The new H238 "old style class declaration, use new style (inherit from `object`)" rule was failing and ignored. Change-Id: I9f616d74e4777640cc9441e96f2bd8c1873aaaca --- keystoneclient/common/cms.py | 2 +- keystoneclient/middleware/auth_token.py | 2 +- tox.ini | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/keystoneclient/common/cms.py b/keystoneclient/common/cms.py index 19390f216..c5faf96d1 100644 --- a/keystoneclient/common/cms.py +++ b/keystoneclient/common/cms.py @@ -42,7 +42,7 @@ PKI_ASN1_FORM = 'PEM' # The openssl cms command exits with these status codes. # See https://www.openssl.org/docs/apps/cms.html#EXIT_CODES -class OpensslCmsExitStatus: +class OpensslCmsExitStatus(object): SUCCESS = 0 INPUT_FILE_READ_ERROR = 2 CREATE_CMS_READ_MIME_ERROR = 3 diff --git a/keystoneclient/middleware/auth_token.py b/keystoneclient/middleware/auth_token.py index 43a7ea5c9..c8d1b083a 100644 --- a/keystoneclient/middleware/auth_token.py +++ b/keystoneclient/middleware/auth_token.py @@ -342,7 +342,7 @@ LIST_OF_VERSIONS_TO_ATTEMPT = ['v2.0', 'v3.0'] CACHE_KEY_TEMPLATE = 'tokens/%s' -class BIND_MODE: +class BIND_MODE(object): DISABLED = 'disabled' PERMISSIVE = 'permissive' STRICT = 'strict' diff --git a/tox.ini b/tox.ini index 49586a554..a050f6ed1 100644 --- a/tox.ini +++ b/tox.ini @@ -34,8 +34,7 @@ commands = oslo_debug_helper -t keystoneclient/tests {posargs} # H304: no relative imports # H405: multi line docstring summary not separated with an empty line # E122: continuation line missing indentation or outdented -# New from hacking 0.10: H238 -ignore = H238,H304,H405,E122 +ignore = H304,H405,E122 show-source = True exclude = .venv,.tox,dist,doc,*egg,build,*openstack/common*