openstack/python-keystoneclient
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests

Browse Source 
Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I8ba72d345ad00f5cde8696ab82c31606ca82a13f
This commit is contained in:
zhang-jinnan
2014-02-17 20:00:17 +08:00
parent 4917f1347a
commit e8f2631b91
4 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
keystoneclient/tests/test_base.py
View File

@@ -72,7 +72,7 @@ class BaseTest(utils.TestCase):
def test_human_id(self): def test_human_id(self):
r = base.Resource(None, {"name": "1 of !"}) r = base.Resource(None, {"name": "1 of !"})
self.assertEqual(r.human_id, None) self.assertIsNone(r.human_id)
r = HumanReadable(None, {"name": "1 of !"}) r = HumanReadable(None, {"name": "1 of !"})
self.assertEqual(r.human_id, "1-of") self.assertEqual(r.human_id, "1-of")

8
keystoneclient/tests/v2_0/test_access.py
View File

@@ -44,11 +44,11 @@ class AccessInfoTest(utils.TestCase, testresources.ResourcedTestCase):
self.assertEqual(auth_ref.role_names, []) self.assertEqual(auth_ref.role_names, [])
self.assertEqual(auth_ref.tenant_name, None) self.assertIsNone(auth_ref.tenant_name)
self.assertEqual(auth_ref.tenant_id, None) self.assertIsNone(auth_ref.tenant_id)
self.assertEqual(auth_ref.auth_url, None) self.assertIsNone(auth_ref.auth_url)
self.assertEqual(auth_ref.management_url, None) self.assertIsNone(auth_ref.management_url)
self.assertFalse(auth_ref.scoped) self.assertFalse(auth_ref.scoped)
self.assertFalse(auth_ref.domain_scoped) self.assertFalse(auth_ref.domain_scoped)

2
keystoneclient/tests/v2_0/test_service_catalog.py
View File

@@ -136,7 +136,7 @@ class ServiceCatalogTest(utils.TestCase):
self.assertEqual(urls[0], 'https://image.south.host/v1/') self.assertEqual(urls[0], 'https://image.south.host/v1/')
urls = sc.get_urls(service_type='image', region_name='West') urls = sc.get_urls(service_type='image', region_name='West')
self.assertEqual(urls, None) self.assertIsNone(urls)
def test_service_catalog_param_overrides_body_region(self): def test_service_catalog_param_overrides_body_region(self):
self.AUTH_RESPONSE_BODY['access']['region_name'] = "North" self.AUTH_RESPONSE_BODY['access']['region_name'] = "North"

2
keystoneclient/tests/v3/test_service_catalog.py
View File

@@ -151,7 +151,7 @@ class ServiceCatalogTest(utils.TestCase):
self.assertEqual(urls[0], self.south_endpoints['public']) self.assertEqual(urls[0], self.south_endpoints['public'])
urls = sc.get_urls(service_type='image', region_name='West') urls = sc.get_urls(service_type='image', region_name='West')
self.assertEqual(urls, None) self.assertIsNone(urls)
def test_service_catalog_param_overrides_body_region(self): def test_service_catalog_param_overrides_body_region(self):
self.AUTH_RESPONSE_BODY['token']['region_name'] = "North" self.AUTH_RESPONSE_BODY['token']['region_name'] = "North"