Files
python-keystoneclient/keystoneclient/tests/unit/test_base.py
Rui Chen fcbb2d7248 Fix Resource.__eq__ mismatch semantics of object equal
The __eq__ of apiclient.base.Resource will return True,
if the two objects have same id, even if they have different
other attributes value. The behavior is weird and don't
match the semantics of object equal. The objects that have
different value should be different objects.
Fix this issue and add some test cases in this patch.

Change-Id: I1565c6e66d6dd6cf7bd2b7e8526157190deb45de
Closes-Bug: #1499369
2015-12-16 07:53:31 +00:00

183 lines
6.6 KiB
Python

# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from oslotest import mockpatch
from keystoneclient import base
from keystoneclient.tests.unit import utils
from keystoneclient.v2_0 import client
from keystoneclient.v2_0 import roles
class HumanReadable(base.Resource):
HUMAN_ID = True
class BaseTest(utils.TestCase):
def test_resource_repr(self):
r = base.Resource(None, dict(foo="bar", baz="spam"))
self.assertEqual(repr(r), "<Resource baz=spam, foo=bar>")
def test_getid(self):
self.assertEqual(base.getid(4), 4)
class TmpObject(object):
id = 4
self.assertEqual(base.getid(TmpObject), 4)
def test_resource_lazy_getattr(self):
# Creating a Client not using session is deprecated.
with self.deprecations.expect_deprecations_here():
self.client = client.Client(token=self.TEST_TOKEN,
auth_url='http://127.0.0.1:5000',
endpoint='http://127.0.0.1:5000')
self.useFixture(mockpatch.PatchObject(
self.client._adapter, 'get', side_effect=AttributeError,
autospec=True))
f = roles.Role(self.client.roles, {'id': 1, 'name': 'Member'})
self.assertEqual(f.name, 'Member')
# Missing stuff still fails after a second get
self.assertRaises(AttributeError, getattr, f, 'blahblah')
def test_eq(self):
# Two resources with same ID: never equal if their info is not equal
r1 = base.Resource(None, {'id': 1, 'name': 'hi'})
r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
self.assertNotEqual(r1, r2)
# Two resources with same ID: equal if their info is equal
r1 = base.Resource(None, {'id': 1, 'name': 'hello'})
r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
self.assertEqual(r1, r2)
# Two resoruces of different types: never equal
r1 = base.Resource(None, {'id': 1})
r2 = roles.Role(None, {'id': 1})
self.assertNotEqual(r1, r2)
# Two resources with no ID: equal if their info is equal
r1 = base.Resource(None, {'name': 'joe', 'age': 12})
r2 = base.Resource(None, {'name': 'joe', 'age': 12})
self.assertEqual(r1, r2)
r1 = base.Resource(None, {'id': 1})
self.assertNotEqual(r1, object())
self.assertNotEqual(r1, {'id': 1})
def test_human_id(self):
r = base.Resource(None, {"name": "1 of !"})
self.assertIsNone(r.human_id)
r = HumanReadable(None, {"name": "1 of !"})
self.assertEqual(r.human_id, "1-of")
class ManagerTest(utils.TestCase):
body = {"hello": {"hi": 1}}
url = "/test-url"
def setUp(self):
super(ManagerTest, self).setUp()
# Creating a Client not using session is deprecated.
with self.deprecations.expect_deprecations_here():
self.client = client.Client(token=self.TEST_TOKEN,
auth_url='http://127.0.0.1:5000',
endpoint='http://127.0.0.1:5000')
self.mgr = base.Manager(self.client)
self.mgr.resource_class = base.Resource
def test_api(self):
with self.deprecations.expect_deprecations_here():
self.assertEqual(self.mgr.api, self.client)
def test_get(self):
get_mock = self.useFixture(mockpatch.PatchObject(
self.client, 'get', autospec=True, return_value=(None, self.body))
).mock
rsrc = self.mgr._get(self.url, "hello")
get_mock.assert_called_once_with(self.url)
self.assertEqual(rsrc.hi, 1)
def test_post(self):
post_mock = self.useFixture(mockpatch.PatchObject(
self.client, 'post', autospec=True, return_value=(None, self.body))
).mock
rsrc = self.mgr._post(self.url, self.body, "hello")
post_mock.assert_called_once_with(self.url, body=self.body)
self.assertEqual(rsrc.hi, 1)
post_mock.reset_mock()
rsrc = self.mgr._post(self.url, self.body, "hello", return_raw=True)
post_mock.assert_called_once_with(self.url, body=self.body)
self.assertEqual(rsrc["hi"], 1)
def test_put(self):
put_mock = self.useFixture(mockpatch.PatchObject(
self.client, 'put', autospec=True, return_value=(None, self.body))
).mock
rsrc = self.mgr._put(self.url, self.body, "hello")
put_mock.assert_called_once_with(self.url, body=self.body)
self.assertEqual(rsrc.hi, 1)
put_mock.reset_mock()
rsrc = self.mgr._put(self.url, self.body)
put_mock.assert_called_once_with(self.url, body=self.body)
self.assertEqual(rsrc.hello["hi"], 1)
def test_patch(self):
patch_mock = self.useFixture(mockpatch.PatchObject(
self.client, 'patch', autospec=True,
return_value=(None, self.body))
).mock
rsrc = self.mgr._patch(self.url, self.body, "hello")
patch_mock.assert_called_once_with(self.url, body=self.body)
self.assertEqual(rsrc.hi, 1)
patch_mock.reset_mock()
rsrc = self.mgr._patch(self.url, self.body)
patch_mock.assert_called_once_with(self.url, body=self.body)
self.assertEqual(rsrc.hello["hi"], 1)
def test_update(self):
patch_mock = self.useFixture(mockpatch.PatchObject(
self.client, 'patch', autospec=True,
return_value=(None, self.body))
).mock
put_mock = self.useFixture(mockpatch.PatchObject(
self.client, 'put', autospec=True, return_value=(None, self.body))
).mock
rsrc = self.mgr._update(
self.url, body=self.body, response_key="hello", method="PATCH",
management=False)
patch_mock.assert_called_once_with(
self.url, management=False, body=self.body)
self.assertEqual(rsrc.hi, 1)
rsrc = self.mgr._update(
self.url, body=None, response_key="hello", method="PUT",
management=True)
put_mock.assert_called_once_with(self.url, management=True, body=None)
self.assertEqual(rsrc.hi, 1)