openstack/python-magnumclient
Code Issues Proposed changes

Add __ne__ built-in function

Browse Source 
In Python 3 __ne__ by default delegates to __eq__ and inverts the
result, but in Python 2 they urge you to define __ne__ when you
define __eq__ for it to work properly [1].There are no implied
relationships among the comparison operators. The truth of x==y
does not imply that x!=y is false. Accordingly, when defining __eq__(),
one should also define __ne__() so that the operators will behave as
expected.
[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__

Change-Id: If2cc9f72acbc444df107f95bded08a398a5d8be3
This commit is contained in:
melissaml 2016-10-19 04:34:14 +08:00
parent 7829c8c901
commit 2fa1fd661d
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
magnumclient/common/apiclient/base.py
View File

@ -521,6 +521,9 @@ class Resource(object):
return self.id == other.id return self.id == other.id
return self._info == other._info return self._info == other._info
def __ne__(self, other):
return not self.__eq__(other)
def is_loaded(self): def is_loaded(self):
return self._loaded return self._loaded