From 3833c46ba49471eb7c2ab706704ce5fa90710a76 Mon Sep 17 00:00:00 2001
From: Dale Smith <dale@catalystcloud.nz>
Date: Fri, 10 May 2024 09:52:00 +1200
Subject: [PATCH] Refactor TLS cert fetching for config

* No longer generate Key,CSR and sign cert if use_keystone is set.
* Break complex section into smaller functions.

Change-Id: I500d9421d188c98daa685aaff79968a935ce8371
---
 magnumclient/osc/v1/clusters.py   | 67 +++++++++++++++++++++++--------
 magnumclient/v1/clusters_shell.py |  1 +
 2 files changed, 51 insertions(+), 17 deletions(-)

diff --git a/magnumclient/osc/v1/clusters.py b/magnumclient/osc/v1/clusters.py
index ace6f34b..cda31b2a 100644
--- a/magnumclient/osc/v1/clusters.py
+++ b/magnumclient/osc/v1/clusters.py
@@ -438,30 +438,63 @@ class ConfigCluster(command.Command):
 
         cluster_template = mag_client.cluster_templates.get(
             cluster.cluster_template_id)
-        opts = {
-            'cluster_uuid': cluster.uuid,
-        }
 
-        tls = None
-        if not cluster_template.tls_disabled:
-            tls = magnum_utils.generate_csr_and_key()
-            tls['ca'] = mag_client.certificates.get(**opts).pem
-            opts['csr'] = tls['csr']
-            tls['cert'] = mag_client.certificates.create(**opts).pem
-            if parsed_args.output_certs:
-                for k in ('key', 'cert', 'ca'):
-                    fname = "%s/%s.pem" % (parsed_args.dir, k)
-                    if os.path.exists(fname) and not parsed_args.force:
-                        raise Exception("File %s exists, aborting." % fname)
-                    else:
-                        with open(fname, "w") as f:
-                            f.write(tls[k])
+        tls = self._fetch_tls(
+            mag_client=mag_client,
+            cluster_uuid=cluster.uuid,
+            tls_required=(not cluster_template.tls_disabled),
+            certkey_required=(not parsed_args.use_keystone)
+        )
+
+        if parsed_args.output_certs:
+            self._write_certs(
+                certs=tls,
+                path=parsed_args.dir,
+                force=parsed_args.force
+            )
 
         print(magnum_utils.config_cluster(
             cluster, cluster_template, parsed_args.dir,
             force=parsed_args.force, certs=tls,
             use_keystone=parsed_args.use_keystone))
 
+    def _fetch_tls(
+            self,
+            mag_client,
+            cluster_uuid,
+            tls_required,
+            certkey_required=True,
+    ):
+        if not tls_required:
+            return {}
+        opts = {
+            'cluster_uuid': cluster_uuid,
+        }
+        tls = {
+            'ca': mag_client.certificates.get(**opts).pem
+        }
+
+        if certkey_required:
+            csr = magnum_utils.generate_csr_and_key()
+            opts['csr'] = csr['csr']
+            tls['cert'] = mag_client.certificates.create(**opts).pem
+            tls['key'] = csr['key']
+        return tls
+
+    def _write_certs(self, certs, path, force):
+        for k in ('key', 'cert', 'ca'):
+            fname = "%s/%s.pem" % (path, k)
+            if os.path.exists(fname):
+                if not force:
+                    raise Exception("File %s exists, aborting." % fname)
+                os.remove(fname)
+
+            if k not in certs:
+                # key and cert aren't always generated
+                continue
+            with open(fname, "w") as f:
+                f.write(certs[k])
+
 
 class ResizeCluster(command.Command):
     _description = _("Resize a Cluster")
diff --git a/magnumclient/v1/clusters_shell.py b/magnumclient/v1/clusters_shell.py
index e46b3f94..17b99b49 100644
--- a/magnumclient/v1/clusters_shell.py
+++ b/magnumclient/v1/clusters_shell.py
@@ -269,6 +269,7 @@ def do_cluster_config(cs, args):
         'cluster_uuid': cluster.uuid,
     }
 
+    # Create a new Certificate and Key, sign it
     if not cluster_template.tls_disabled:
         tls = magnum_utils.generate_csr_and_key()
         tls['ca'] = cs.certificates.get(**opts).pem