openstack/python-magnumclient
Code Issues Proposed changes

Remove the update function of container

Browse Source 
The container update function isn't called by any function.
So we should delete it.

Change-Id: I832b2082f8da441a7924623c29df2255fbd7ad28
Closes-Bug: #1562236
This commit is contained in:
wangqun 2016-03-26 02:27:57 +00:00
parent 10362d5944
commit 741dcb5277
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
magnumclient/tests/v1/test_containers.py
View File

@ -368,17 +368,6 @@ class ContainerManagerTest(testtools.TestCase):
self.assertEqual(expect, self.api.calls)
self.assertIsNone(container)
def test_container_update(self):
patch = {'op': 'replace',
'value': NEW_NAME,
'path': '/name'}
container = self.mgr.update(id=CONTAINER1['id'], patch=patch)
expect = [
('PATCH', '/v1/containers/%s' % CONTAINER1['id'], {}, patch),
]
self.assertEqual(expect, self.api.calls)
self.assertEqual(NEW_NAME, container.name)
def test_container_start(self):
container = self.mgr.start(CONTAINER1['id'])
expect = [

3
magnumclient/v1/containers.py
View File

@ -110,9 +110,6 @@ class ContainerManager(base.Manager):
def delete(self, id):
return self._delete(self._path(id))
def update(self, id, patch):
return self._update(self._path(id), patch)
def _action(self, id, action, method='PUT', qparams=None, **kwargs):
if qparams:
action = "%s?%s" % (action,