6091ddf6c5
Prevent list rcs when bay is not ready, otherwise it will return: $ magnum rc-list --bay k8sbay ERROR: unsupported operand type(s) for +: 'NoneType' and 'str' (HTTP 500) Which makes no sense. Also added unit test for this case. Change-Id: Ib869f6e9a187a3e99a2e38ea19b882c87c195726
133 lines
5.8 KiB
Python
133 lines
5.8 KiB
Python
# Copyright 2015 NEC Corporation. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from magnumclient import exceptions
|
|
from magnumclient.tests.v1 import shell_test_base
|
|
|
|
|
|
class ShellTest(shell_test_base.TestCommandLineArgument):
|
|
|
|
@mock.patch('magnumclient.v1.bays.BayManager.get')
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.list')
|
|
def test_rc_list_success(self, mock_list, mock_get):
|
|
mockbay = mock.MagicMock()
|
|
mockbay.status = "CREATE_COMPLETE"
|
|
mock_get.return_value = mockbay
|
|
self._test_arg_success('rc-list --bay bay_ident')
|
|
self.assertTrue(mock_list.called)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.list')
|
|
def test_rc_list_failure(self, mock_list):
|
|
self._test_arg_failure('rc-list --bay bay_ident --wrong',
|
|
self._unrecognized_arg_error)
|
|
self.assertFalse(mock_list.called)
|
|
|
|
@mock.patch('magnumclient.v1.bays.BayManager.get')
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.list')
|
|
def test_rc_list_failure_invalid_bay_status(self, mock_list, mock_get):
|
|
mockbay = mock.MagicMock()
|
|
mockbay.status = "CREATE_IN_PROGRESS"
|
|
mock_get.return_value = mockbay
|
|
self.assertRaises(exceptions.InvalidAttribute, self._test_arg_failure,
|
|
'rc-list --bay bay_ident', self._bay_status_error)
|
|
self.assertFalse(mock_list.called)
|
|
|
|
@mock.patch('magnumclient.v1.bays.BayManager.get')
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.create')
|
|
def test_rc_create_success(self, mock_create, mock_get):
|
|
mockbay = mock.MagicMock()
|
|
mockbay.status = "CREATE_COMPLETE"
|
|
mock_get.return_value = mockbay
|
|
|
|
self._test_arg_success('rc-create '
|
|
'--bay xxx '
|
|
'--manifest test '
|
|
'--manifest-url test_url')
|
|
self.assertTrue(mock_create.called)
|
|
|
|
@mock.patch('magnumclient.v1.bays.BayManager.get')
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.create')
|
|
def test_rc_create_failure_few_arg(self, mock_create, mock_get):
|
|
self._test_arg_failure('rc-create '
|
|
'--manifest test '
|
|
'--manifest-url test_url',
|
|
self._mandatory_arg_error)
|
|
self.assertFalse(mock_create.called)
|
|
|
|
self._test_arg_failure('rc-create '
|
|
'bay xxx '
|
|
'--manifest-url test_url',
|
|
self._mandatory_arg_error)
|
|
self.assertFalse(mock_create.called)
|
|
|
|
@mock.patch('magnumclient.v1.bays.BayManager.get')
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.create')
|
|
def test_rc_create_failure_invalid_bay_status(self, mock_create, mock_get):
|
|
mockbay = mock.MagicMock()
|
|
mockbay.status = "CREATE_IN_PROGRESS"
|
|
mock_get.return_value = mockbay
|
|
self.assertRaises(exceptions.InvalidAttribute, self._test_arg_failure,
|
|
'rc-create '
|
|
'--bay xxx '
|
|
'--manifest test '
|
|
'--manifest-url test_url',
|
|
self._bay_status_error)
|
|
self.assertFalse(mock_create.called)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.delete')
|
|
def test_rc_delete_success(self, mock_delete):
|
|
self._test_arg_success('rc-delete xxx --bay zzz')
|
|
self.assertTrue(mock_delete.called)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.delete')
|
|
def test_rc_delete_failure_no_arg(self, mock_delete):
|
|
self._test_arg_failure('rc-delete xxx', self._mandatory_arg_error)
|
|
self.assertFalse(mock_delete.called)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.get')
|
|
def test_rc_show_success(self, mock_show):
|
|
self._test_arg_success('rc-show xxx --bay zzz')
|
|
self.assertTrue(mock_show.called)
|
|
self.assertEqual(1, mock_show.call_count)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.get')
|
|
def test_rc_show_failure_no_arg(self, mock_show):
|
|
self._test_arg_failure('rc-show xxx', self._mandatory_arg_error)
|
|
self.assertFalse(mock_show.called)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.update')
|
|
def test_rc_update_success(self, mock_update):
|
|
self._test_arg_success('rc-update xxx --bay zzz replace xxx=xxx')
|
|
self.assertTrue(mock_update.called)
|
|
self.assertEqual(1, mock_update.call_count)
|
|
|
|
@mock.patch('magnumclient.v1.replicationcontrollers.'
|
|
'ReplicationControllerManager.update')
|
|
def test_rc_update_failure_no_arg(self, mock_update):
|
|
self._test_arg_failure('rc-update xxx', self._few_argument_error)
|
|
self.assertFalse(mock_update.called)
|