bafc850379
Currently assertTrue and assertFalse are used to check wheter a mock method is called. It is not checked whether mock method is called with correct set of arguments. With this patch following modules uses assert_called_* and assert_not_called instead of assertTrue and assertFalse. - magnumclient/tests/v1/test_certificates_shell.py - magnumclient/tests/v1/test_mservices_shell.py Also, renamed "file_mock" to "mock_file" for consistent mock naming in the modules. Change-Id: I706b362509f6a59be13df8d9c132e4f4b68e0060 Partially-Implements: blueprint magnumclient-ut-coverage
32 lines
1.2 KiB
Python
32 lines
1.2 KiB
Python
# Copyright 2015 NEC Corporation. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
|
|
from magnumclient.tests.v1 import shell_test_base
|
|
|
|
|
|
class ShellTest(shell_test_base.TestCommandLineArgument):
|
|
|
|
@mock.patch('magnumclient.v1.mservices.MServiceManager.list')
|
|
def test_magnum_service_list_success(self, mock_list):
|
|
self._test_arg_success('service-list')
|
|
mock_list.assert_called_once_with()
|
|
|
|
@mock.patch('magnumclient.v1.mservices.MServiceManager.list')
|
|
def test_magnum_service_list_failure(self, mock_list):
|
|
self._test_arg_failure('service-list --wrong',
|
|
self._unrecognized_arg_error)
|
|
mock_list.assert_not_called()
|