openstack/python-manilaclient
Code Issues Proposed changes

Fix formatting of OSC server migration check-only

Browse Source 
When the default table formatting is used, we can improve
readability by transforming the capabilities dictionaries
into paragraphs.

Closes-Bug: #1989817

Change-Id: I5479c12ff97c12fbb5ab06d161d37b1dd736e8a2
This commit is contained in:
kushalaa 2022-09-16 16:44:07 -07:00
parent cb78d0e17b
commit 05135dc1e2
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
manilaclient/osc/v2/share_servers.py
View File

@ -21,6 +21,7 @@ from osc_lib import utils as osc_utils
from manilaclient import api_versions
from manilaclient.common._i18n import _
from manilaclient.common.apiclient import utils as apiutils
from manilaclient.common import cliutils
from manilaclient.common import constants
LOG = logging.getLogger(__name__)
@ -624,6 +625,14 @@ class ShareServerMigrationStart(command.ShowOne):
new_share_net_id
)
if result:
if parsed_args.formatter == 'table':
for k, v in result.items():
if isinstance(v, dict):
capabilities_list = [v]
dict_values = cliutils.convert_dict_list_to_string(
capabilities_list
)
result[k] = dict_values
return self.dict2columns(result)
else:
share_server.migration_start(parsed_args.host,