openstack/python-manilaclient
Code Issues Proposed changes

Fix incompatible headers on OS share group type list

Browse Source 
Headers should be displayed in camel case and with blank spaces
between words now, instead of underscores.

Closes-Bug: #1973759
Change-Id: I75b1aff12dac059ac7192e58a70df86b5db833c6
This commit is contained in:
silvacarloss 2022-05-18 11:16:05 -03:00
parent bf2c7a26d6
commit 2f11d143e0
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manilaclient/osc/v2/share_group_types.py
View File

@ -207,10 +207,11 @@ class ListShareGroupType(command.Lister):
formatted_types.append(utils.format_share_group_type(
share_group_type, formatter))
column_headers = utils.format_column_headers(ATTRIBUTES)
values = (oscutils.get_dict_properties(
sgt, ATTRIBUTES) for sgt in formatted_types)
return (ATTRIBUTES, values)
return (column_headers, values)
class ShowShareGroupType(command.ShowOne):

12
manilaclient/tests/unit/osc/v2/test_share_group_type.py
View File

@ -25,12 +25,12 @@ from manilaclient.tests.unit.osc import osc_utils
from manilaclient.tests.unit.osc.v2 import fakes as manila_fakes
COLUMNS = [
'id',
'name',
'share_types',
'visibility',
'is_default',
'group_specs',
'ID',
'Name',
'Share Types',
'Visibility',
'Is Default',
'Group Specs',
]