From 635dd032fa5f28e678bd1bb520f4a08af56ce860 Mon Sep 17 00:00:00 2001
From: Alexander Pugachev <alexander.pugachev@workday.com>
Date: Tue, 23 Jan 2018 09:54:08 +0000
Subject: [PATCH] Cover string representations of api_versions.APIVersion

Adding unit-tests to check string representation and repr()
results for api_versions.APIVersion instances.
Both for valid versions and null.

This increases code coverage.

Change-Id: I53125c0f993a54812d47341c7956222b7da65c7f
Partial-Bug: #1364800
---
 manilaclient/tests/unit/test_api_versions.py | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/manilaclient/tests/unit/test_api_versions.py b/manilaclient/tests/unit/test_api_versions.py
index 3a3111ecc..4ba337fd7 100644
--- a/manilaclient/tests/unit/test_api_versions.py
+++ b/manilaclient/tests/unit/test_api_versions.py
@@ -14,6 +14,7 @@
 
 import ddt
 import mock
+import six
 
 import manilaclient
 from manilaclient import api_versions
@@ -40,6 +41,7 @@ class APIVersionTestCase(utils.TestCase):
     def test_null_version(self):
         v = api_versions.APIVersion()
         self.assertTrue(v.is_null())
+        self.assertEqual(repr(v), "<APIVersion: null>")
 
     @ddt.data(
         "2",
@@ -115,6 +117,22 @@ class APIVersionTestCase(utils.TestCase):
         self.assertRaises(ValueError,
                           api_versions.APIVersion().get_string)
 
+    @ddt.data("2.0",
+              "2.5",
+              "2.45",
+              "3.3",
+              "3.23",
+              "2.0",
+              "3.3",
+              "4.0")
+    def test_representation(self, version):
+        version_major, version_minor = version.split('.')
+        api_version = api_versions.APIVersion(version)
+        self.assertEqual(six.text_type(api_version),
+                         ("API Version Major: %s, Minor: %s" %
+                          (version_major, version_minor)))
+        self.assertEqual(repr(api_version), "<APIVersion: %s>" % version)
+
 
 class GetAPIVersionTestCase(utils.TestCase):