openstack/python-manilaclient
Code Issues Proposed changes

Return is_default as a value instead of a function object

Browse Source 
Closes-Bug: #1802059

Change-Id: I4df0afdb9188043150fc505d55fd26a1bcb4654e
This commit is contained in:
sriram ramakrishnan 2019-01-07 20:37:34 -05:00
parent 6a4ad5cfee
commit 53da67c419
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manilaclient/tests/unit/v2/test_shell.py
View File

@ -2528,7 +2528,7 @@ class ShellTest(test_utils.TestCase):
'type1,type2 --is-public %s --group-specs '
'spec1=value1' % six.text_type(public))
self.assert_called('POST', '/share-group-types', body=expected)
self.assert_called_anytime('POST', '/share-group-types', body=expected)
def test_share_group_type_delete(self):
fake_share_group_type = type(

2
manilaclient/v2/shell.py
View File

@ -4114,7 +4114,7 @@ def _print_share_group_type(share_group_type, default_share_type=None):
'ID': share_group_type.id,
'Name': share_group_type.name,
'Visibility': _is_share_type_public(share_group_type),
'is_default': _is_default
'is_default': _is_default(share_group_type)
}
cliutils.print_dict(share_group_type_dict)

3
releasenotes/notes/bug-1802059-fix-is_default-a8d3d95ffa0aede9.yaml Normal file
View File

@ -0,0 +1,3 @@
---
fixes:
- Fix share_group_type_create returning is_default as a function object instead of value