Merge "adds bandit testing and Zuul CI job."

manilaclient/base.py

@@ -129,7 +129,7 @@ class Manager(utils.HookableMixin):
         # pair
         username = cliutils.env('OS_USERNAME', 'MANILA_USERNAME')
         url = cliutils.env('OS_URL', 'MANILA_URL')
-        uniqifier = hashlib.sha1(username.encode('utf-8') +
+        uniqifier = hashlib.sha256(username.encode('utf-8') +
                                    url.encode('utf-8')).hexdigest()
 
         cache_dir = os.path.expanduser(os.path.join(base_dir, uniqifier))

tox.ini

@@ -90,6 +90,10 @@ commands =
   coverage xml -o cover/coverage.xml
   coverage report
 
+[testenv:bandit]
+deps = bandit
+commands = bandit -r manilaclient -x  manilaclient/tests/* -n5 -ll
+
 [flake8]
 # F821: undefined name
 # W503 line break before binary operator

zuul.d/project.yaml

@@ -8,6 +8,7 @@
     check:
       jobs:
         - python-manilaclient-functional
+        - python-manilaclient-tox-bandit
         - manila-rally-ss:
             voting: false
         - python-manilaclient-functional-fips:

zuul.d/python-manilaclient-jobs.yaml

@@ -92,3 +92,10 @@
     vars:
       configure_swap_size: 4096
       nslookup_target: 'opendev.org'
+
+- job:
+    name: python-manilaclient-tox-bandit
+    parent: openstack-tox
+    timeout: 2400
+    vars:
+      tox_envlist: bandit