Update patch set 9

Patch Set 9: Code-Review-1

(3 comments)

Patch-set: 9
Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, aa2336661a58f849732b6dbf611e61f99ec771d8
Attention: {"person_ident":"Gerrit User 36889 \u003c36889@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
Gerrit User 16643 2024-04-05 16:59:57 +00:00 committed by Gerrit Code Review
parent b8f5d2c846
commit 6a1f2b557b
1 changed files with 67 additions and 0 deletions

View File

@ -0,0 +1,67 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "9fdf780a_bd7f6301",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 9
},
"lineNbr": 0,
"author": {
"id": 16643
},
"writtenOn": "2024-04-05T16:59:57Z",
"side": 1,
"message": "Thanks for the changes! Please see my comment inline",
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1909421a_deaacac4",
"filename": "manilaclient/v2/shell.py",
"patchSetId": 9
},
"lineNbr": 395,
"author": {
"id": 16643
},
"writtenOn": "2024-04-05T16:59:57Z",
"side": 1,
"message": "these keys aren\u0027t present in a share server; see https://docs.openstack.org/api-ref/shared-file-system/index.html#id441",
"range": {
"startLine": 390,
"startChar": 0,
"endLine": 395,
"endChar": 51
},
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d1d60344_2a85b650",
"filename": "manilaclient/v2/shell.py",
"patchSetId": 9
},
"lineNbr": 4660,
"author": {
"id": 16643
},
"writtenOn": "2024-04-05T16:59:57Z",
"side": 1,
"message": "This is how a share server\u0027s being printed; can you use this logic in _print_share_server and replace this code with a call to that method as well?",
"range": {
"startLine": 4658,
"startChar": 0,
"endLine": 4660,
"endChar": 43
},
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}