openstack/python-manilaclient
Code Issues Proposed changes

Add GlusterFS protocol as a supported Share/NAS type

Browse Source 
This patch adds GlusterFS as a supported protocol (in addition
to NFS and CIFS) in the Share/NAS type doc/help string. Since the
Manila server side now support cert based access type which
introduced 'glusterfs' as a new share protocol, this patch
updates the manilaclient help/doc string to reflect the same.

'glusterfs' protocol support was added to server side using:
https://review.openstack.org/116859

Change-Id: I94cbecd55fabbfd1bb7c06184e4679c7531d0214
Closes-Bug: #1367205
This commit is contained in:
Deepak C Shetty 2014-09-09 09:53:50 +00:00
parent d70dee0923
commit ce3180d823
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manilaclient/v1/shell.py
View File

@ -311,7 +311,7 @@ def do_rate_limits(cs, args):
'share_protocol',
metavar='<share_protocol>',
type=str,
help='Share type (NFS or CIFS).')
help='Share type (NFS, CIFS or GlusterFS).')
@cliutils.arg(
'size',
metavar='<size>',
@ -351,7 +351,7 @@ def do_rate_limits(cs, args):
default=None)
@cliutils.service_type('share')
def do_create(cs, args):
"""Creates new NAS storage (NFS or CIFS)."""
"""Creates new NAS storage (NFS, CIFS or GlusterFS)."""
share_metadata = None
if args.metadata is not None:

3
tests/test_shell.py
View File

@ -60,7 +60,8 @@ class ShellTest(utils.TestCase):
def test_help(self):
required = [
'.*?^usage: ',
'.*?^\s+create\s+Creates new NAS storage \(NFS or CIFS\).',
'.*?^\s+create\s+Creates new NAS storage '
'\(NFS, CIFS or GlusterFS\).',
'.*?(?m)^See "manila help COMMAND" for help '
'on a specific command.',
]