openstack/python-manilaclient
Code Issues Proposed changes

Fix the id attr for share group type access repr

Browse Source 
The correct attribute name for the share group type access
repr is share_group_type_id, not id. This patch set fixes that.

Closes-Bug: #1953670
Change-Id: I651f3cc6429801db4c04813a60ddb4ec2871f2a1
This commit is contained in:
Victoria Martinez de la Cruz 2021-12-08 17:41:04 +00:00
parent 4ec4c58567
commit dcb25e54e9
3 changed files with 8 additions and 2 deletions

3
manilaclient/tests/unit/v2/test_share_group_type_access.py

@ -31,7 +31,8 @@ class ShareGroupTypeAccessTest(utils.TestCase):
super(ShareGroupTypeAccessTest, self).setUp() super(ShareGroupTypeAccessTest, self).setUp()
self.manager = type_access.ShareGroupTypeAccessManager( self.manager = type_access.ShareGroupTypeAccessManager(
fake.FakeClient()) fake.FakeClient())
fake_group_type_access_info = {'id': fake.ShareGroupTypeAccess.id} fake_group_type_access_info = {
'share_group_type_id': fake.ShareGroupTypeAccess.id}
self.share_group_type_access = type_access.ShareGroupTypeAccess( self.share_group_type_access = type_access.ShareGroupTypeAccess(
self.manager, fake_group_type_access_info, loaded=True) self.manager, fake_group_type_access_info, loaded=True)

2
manilaclient/v2/share_group_type_access.py

@ -26,7 +26,7 @@ SG_GRADUATION_VERSION = "2.55"
class ShareGroupTypeAccess(common_base.Resource): class ShareGroupTypeAccess(common_base.Resource):
def __repr__(self): def __repr__(self):
return "<Share Group Type Access: %s>" % self.id return "<Share Group Type Access: %s>" % self.share_group_type_id
class ShareGroupTypeAccessManager(base.ManagerWithFind): class ShareGroupTypeAccessManager(base.ManagerWithFind):

5
releasenotes/notes/bug-1953670-fix-id-attr-for-share-group-type-access-repr-008338a53d7a6a50.yaml Normal file

@ -0,0 +1,5 @@
---
fixes:
- Launchpad `bug 1953670 <https://bugs.launchpad.net/python-manilaclient/+bug/1953670>`_
has been fixed by updating the attribute name for the share group type access
repr to be share_group_type_id.