Add consistency to displaying column headers for the following
list commands:
openstack share type list
openstack share type access list
openstack share access list
Partial-Bug: #1945170
Change-Id: I88b3103696ab2f47b11d6d938193788e69b5a739
Optimize usage of logger so that manilla client does not
import logger library when not needed.
Closes-Bug: #1940692
Change-Id: Idcd327c1f4a2d0b56eb8487fcc885e5e744f0289
Share groups and share group snapshots can be now updated
through the quota class API
This change adds this option to the manilaclient CLI
Closes-Bug: #1871252
Change-Id: If2faf8a88a0a0e39d7fd0554bc3e530e18c3e922
Bump the lowest version of openstacksdk to 0.53.0
(shipped during wallaby cycle). Align some other
lower constraints (decorator, dogpile.cache,
keystoneauth1) to the versions constrained by
that release of openstacksdk.
Change-Id: I24f88cbc545f9c7503b9ccefb3d83a0976248a7d
Depends-On: I1b3a463211b65b6aaa3e0e127a1b32962ad6bf9f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Fixes share server migration functional tests in the
python-manilaclient. Recently, this change [1] was introduced, and
before such change was merged, Manila used to keep the source share
server even after the complete operation.
As of the merge of [1], Manila is no longer keeping the source
share server, and it is automatically removed after the complete
phase is triggered.
In this change, we stop waiting for the share server task state
to be a migration completed task state, and instead, expect that
the source share server won't be encountered after the migration
complete.
[1] https://review.opendev.org/c/openstack/manila/+/803623
Change-Id: I7d53a65f1a3b1d5112b3e4de7dc60925191920fa
Add file to the reno documentation build to show release notes for
stable/xena.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/xena.
Sem-Ver: feature
Change-Id: I58fe22d8c9862a2e1826717d7b50450f64e1ab68
This commit add --scheduler_hints option to share create command. Users
can specify affinity/anti-affinity share ids to share create command as
value in <key=value> pairs of scheduler hints. The possible keys are
same_host and different_host. Available from microversion 2.65.
Partially-implements: bp affinity-antiaffinity-filter
Change-Id: I8a9598eb16f08ed6539e8996e28cfc6e19586483
Some issues were identified in the commit
that added share groups OSC commands in
https://review.opendev.org/c/openstack/python-manilaclient/+/801740
We were also missing an import.
Change-Id: If72f4ecafd6c986f44b769fc47970374da9c008b
Partially-implements: bp openstack-client-support
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Added the implementation of the share group commands to OSC.
Commands are:
- openstack share group create
- openstack share group delete
- openstack share group list
- openstack share group show
- openstack share group set
- openstack share group unset
Change-Id: I9eb31449fef4eae73f1db91f2bad133d0fe8df2e
In this patch we add openstack commands for:
- share instance export location show
- share instance export location list
Co-authored-by: Eduardo Santos <eduardo.experimental@gmail.com>
Partially-implements: bp openstack-client-support
Change-Id: Ic1b5616a363059a941caa3cce6bd2b24bd379068
Add the following OSC commands:
share network create
share network list
share network show
share network set
share network unset
share network delete
Partially-implements: bp openstack-client-support
Change-Id: I6ddb2fec1d9421bfa8b11c82da5379ada80f610b
Co-Authored-By: Vida Haririan <vhariria@redhat.com>
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
Adding the following openstack command,
share limits show --absolute
share limits show --rate
Partially-implements: bp openstack-client-support
Co-Authored-By: Goutham Pacha Ravi <gouthampravi@gmail.com>
Change-Id: I68b98a6c3ee369be1422d2f45e75d034e68da2e0
In this patch we add the following openstack share commands:
share snapshot instance list
share snapshot instance show
share snapshot instance set --status
share snapshot instance export location list
share snapshot instance export location show
Partially-implements: bp openstack-client-support
Co-Authored-By: Caique Mello <caiquemellosbo@gmail.com>
Change-Id: I7feb6219b0c684d2e88d0d077f776bfb331e3955
Lookup by 'id' was missing quotes
causing sporadic functional test
failures - sporadic because the test
gets into this code section only when
it runs in parallel to some migration
tests.
Change-Id: Iadce9d910370246f83f56f27039d9f5585642fbc
Related-Bug: #1821945
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>
This commit implements the following openstack share command:
openstack share pool list
Partially-implements: bp openstack-client-support
Change-Id: I5be047d6c81556b45773497f55323d1611c1eb48
This patch set adds the --wait flag to the share group
operation. This will make the CLI to wait for the
operation to be completed before returning to the prompt.
Updated test_share_group_create to be test_share_group_create_wait
and included the waiter flag
Partial-Bug: #1898318
Change-Id: Id3e163de48bdd918ae55438d812187ba4d5461c9
In this patch we add the following openstack share commands:
share replica export location list
share replica export location show
Partially-implements: bp openstack-client-support
Change-Id: Ib7ae453da665ae17b40c7b91b3563bc301769410
In this patch we add the following openstack share commands:
share service list
share sevice set
manila service-enable command is implemented as:
openstack share service set <hostname> <binary> --enable
manila service-disable command is implemented as:
openstack share service set <hostname> <binary> --disable
Partially-implements: bp openstack-client-support
Change-Id: I41852e93fce356549ca0600b02d972742a105a38
This commit implements the following openstack share command:
openstack share availability zone list
Change-Id: I75d3c5441b82fb8f16896719544a81dd032cdd15
Fixed the issue that didn't allow users to create share from
snapshot when the snapshot name was specified instead of the id.
Now, the manila client will search for snapshots regardless if the
name or id of the snapshot was specified.
Closes-Bug: #1798229
Change-Id: I2b29b6d2ba232aa390e7c3708ee589c82e3e7e72
Add missing font for PDF generation.
Now, openstack-tox-docs will succeed with the previous missing
font having been added.
Closes-Bug: #1938044
Change-Id: Ie10393b1eeaaf9cf94165b216bdbacc14d76e7a7
This enables writing ids to a local completion
cache when using the manilaclient shell, which
allows tools/manila.bash_completion to complete
commands such as:
manila delete a<tab>
Share ids are recorded on "manila list" operations.
Caching can be expanded to cover additional
types of manila objects using this same infrastructure.
Uses ~/.cache/manilaclient/ to match path standards,
and uses SHA-1 since Python running w/ FIPS mode may
not have MD5.
Also, fix a small bug in the fakes used in our test suite.
We were adding the shares count (an optional param) to all
the list responses, while this is something that should be done
only if the param with_count is set to True.
Co-Authored-By: Victoria Martinez de la Cruz <victoria@redhat.com>
Closes-Bug: #1712835
Change-Id: I7f4dedf1dd4b7db6cf24fc1c4ed2a8d3685f714c
The API_VERSION in some unit tests for OSC share commands
are set to API microversion 2.51. However, the default value
should be set to MAX_VERSION so the tests would be aligned
with the latest defined microversion.
This patch was submitted during the GHC2021 Summer OSD
Closes-Bug: #1913956
Change-Id: Ibb8c373dbb4620ea8e67d85f641a708162f06d64
inspect.getargspec was deprecated since Python 3.0 and
inspect.getfullargspec is its replacement with correct handling of
function annotations and keyword-only parameters[1].
[1] https://docs.python.org/3/library/inspect.html#inspect.getargspec
Change-Id: Id91cd6dd61a0c1513e9c1bfa5672a156339f1d98
This patch set adds the --wait flag to the share group
operation. This will make the CLI to wait for the
operation to be completed before returning to the prompt.
Updated test_share_delete to be test_share_delete_wait
and included the waiter flag.
Updated test_share_group_delete_force to test the
correct calls.
Also, updated test_share_group_update and test_share_group_show
since they were randomnly failing depending on the test execution
order. Mocks were being cleaned up and that was leading us to
some errors. Created mocks for required resources within those
tests to make it more stable.
Partial-Bug: #1898318
Change-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a
The 'unicode_key_value_to_string' and '_encode' helpers were used to
handle the difference between unicode and byte strings in Python 2. In a
Python 3-only world, they are unnecessary. Remove them.
Some references to text encoding in the HACKING file are removed. In
theory, we should no longer have to worry about byte strings.
Change-Id: I0694b25dc4d72e817cb08ce6cafb39bb8226293d
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
These have been effectively untouched since initial creation of the
project and were copy-pasted from nova. Drop them.
Change-Id: Iaed9d44b9b5d7a1a2ee0469e5cbdfe769090abd9
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This is no longer needed in a Python 3-only world.
Change-Id: I84231b7e8d952b562870838a2fa4ef0d86179183
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
Zuul
Leslie Stevens
celenamichaud
altanai
Victoria Martinez de la Cruz
silvacarloss
OpenStack Release Bot
kpdev
Goutham Pacha Ravi
archanaserver
Nahim Alves de Souza
Vida Haririan
Fabio Oliveira
Maari Tamm
Kafilat Adeleke
Luisa Ferraz do Amaral
Eric Harney
Takashi Kajinami
Stephen Finucane