![Goutham Pacha Ravi](/assets/img/avatar_default.png)
IETF RFC 3986 classifies "~" as a reserved character [1], however until python3.7 [2], python's url parsing used to encode this character. urllib has seen a lot of churn in various python releases, and hence we were using a six wrapper to shield ourselves, however, this backwards-incompatible change in encoding norms forces us to deal with the problem at our end. Manila's API accepts "~" in both, its encoded or un-encoded forms. So, let's stop encoding it within manilaclient, regardless of the version of python running it. [1] https://tools.ietf.org/html/rfc3986.html [2] https://docs.python.org/3/library/urllib.parse.html#url-quoting Closes-Bug: #1785283 Change-Id: I6df5d543ae94ed1fa966c8019a52e9fca19e387e
50 lines
1.6 KiB
Python
50 lines
1.6 KiB
Python
# Copyright (c) 2015 Clinton Knight. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from manilaclient import base
|
|
from manilaclient.common.apiclient import base as common_base
|
|
|
|
RESOURCES_PATH = '/scheduler-stats/pools'
|
|
RESOURCES_NAME = 'pools'
|
|
|
|
|
|
class Pool(common_base.Resource):
|
|
|
|
def __repr__(self):
|
|
return "<Pool: %s>" % self.name
|
|
|
|
|
|
class PoolManager(base.Manager):
|
|
"""Manage :class:`Pool` resources."""
|
|
resource_class = Pool
|
|
|
|
def list(self, detailed=True, search_opts=None):
|
|
"""Get a list of pools.
|
|
|
|
:rtype: list of :class:`Pool`
|
|
"""
|
|
query_string = self._build_query_string(search_opts)
|
|
if detailed:
|
|
path = '%(resources_path)s/detail%(query)s' % {
|
|
'resources_path': RESOURCES_PATH,
|
|
'query': query_string
|
|
}
|
|
else:
|
|
path = '%(resources_path)s%(query)s' % {
|
|
'resources_path': RESOURCES_PATH,
|
|
'query': query_string
|
|
}
|
|
|
|
return self._list(path, RESOURCES_NAME)
|