0ca91287ac
After fixing a bug that was allowing share network update when it shouldn't, the test that validates the share network creation and update started failing. An additional validation was introduced and it caused the new bug. This patch fixes the test and make it work properly. In addition this patch fixes test classes that are raising a skip exception inside the setUpClass function and failing due to testtool issue #272. Closes-Bug: #1849728 Closes-Bug: #1849377 Related-Bug: #1846836 Co-Author: Carlos Eduardo <ces.eduardo98@gmail.com> Change-Id: I5b27ee4a9e844ea48dc9324bcf38f5767223717f
71 lines
2.7 KiB
Python
71 lines
2.7 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import ddt
|
|
|
|
from manilaclient.tests.functional import base
|
|
|
|
|
|
@ddt.ddt
|
|
class MessagesReadOnlyTest(base.BaseTestCase):
|
|
|
|
@ddt.data(
|
|
("admin", "2.37"),
|
|
("user", "2.37"),
|
|
)
|
|
@ddt.unpack
|
|
def test_message_list(self, role, microversion):
|
|
self.skip_if_microversion_not_supported(microversion)
|
|
self.clients[role].manila("message-list", microversion=microversion)
|
|
|
|
|
|
@ddt.ddt
|
|
class MessagesReadWriteTest(base.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(MessagesReadWriteTest, self).setUp()
|
|
self.message = self.create_message()
|
|
|
|
def test_list_messages(self):
|
|
self.skip_if_microversion_not_supported('2.37')
|
|
messages = self.admin_client.list_messages()
|
|
self.assertTrue(any(m['ID'] is not None for m in messages))
|
|
self.assertTrue(any(m['User Message'] is not None for m in messages))
|
|
self.assertTrue(any(m['Resource ID'] is not None for m in messages))
|
|
self.assertTrue(any(m['Action ID'] is not None for m in messages))
|
|
self.assertTrue(any(m['Detail ID'] is not None for m in messages))
|
|
self.assertTrue(any(m['Resource Type'] is not None for m in messages))
|
|
|
|
@ddt.data(
|
|
'id', 'action_id', 'resource_id', 'action_id', 'detail_id',
|
|
'resource_type', 'created_at', 'action_id,detail_id,resource_id',
|
|
)
|
|
def test_list_share_type_select_column(self, columns):
|
|
self.skip_if_microversion_not_supported('2.37')
|
|
self.admin_client.list_messages(columns=columns)
|
|
|
|
def test_get_message(self):
|
|
self.skip_if_microversion_not_supported('2.37')
|
|
message = self.admin_client.get_message(self.message['ID'])
|
|
expected_keys = (
|
|
'id', 'action_id', 'resource_id', 'action_id', 'detail_id',
|
|
'resource_type', 'created_at', 'created_at',
|
|
)
|
|
for key in expected_keys:
|
|
self.assertIn(key, message)
|
|
|
|
def test_delete_message(self):
|
|
self.skip_if_microversion_not_supported('2.37')
|
|
message = self.create_message(cleanup_in_class=False)
|
|
self.admin_client.delete_message(message['ID'])
|
|
self.admin_client.wait_for_message_deletion(message['ID'])
|