bdf2045d95
Manila microversions have following template: x.y where 'x' and 'y' both digits. And now manilaclient functional tests transform string 'x.y' to float, but it is incorrect thing to do because float assumes that each left value is bigger than right one. And it is not suitable for microversion comparisons. Examples: Microversions true conditions: 2.9 < 2.10 2.9 < 2.81 Float true conditions: 2.9 > 2.10 2.9 > 2.81 Change-Id: Ibb20e394cefdab82f7be946ce710a6681224051d Closes-bug: #1518996
92 lines
3.1 KiB
Python
92 lines
3.1 KiB
Python
# Copyright 2015 Mirantis inc.
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import ddt
|
|
import mock
|
|
|
|
from manilaclient import api_versions
|
|
from manilaclient import extension
|
|
from manilaclient.tests.unit import utils
|
|
from manilaclient.tests.unit.v2 import fakes
|
|
from manilaclient.v2 import share_instances
|
|
|
|
|
|
extensions = [
|
|
extension.Extension('share_instances', share_instances),
|
|
]
|
|
cs = fakes.FakeClient(extensions=extensions)
|
|
|
|
|
|
@ddt.ddt
|
|
class ShareInstancesTest(utils.TestCase):
|
|
|
|
def _get_manager(self, microversion):
|
|
version = api_versions.APIVersion(microversion)
|
|
mock_microversion = mock.Mock(api_version=version)
|
|
return share_instances.ShareInstanceManager(api=mock_microversion)
|
|
|
|
def test_list(self):
|
|
cs.share_instances.list()
|
|
cs.assert_called('GET', '/share_instances')
|
|
|
|
def test_get(self):
|
|
instance = type('None', (object, ), {'id': '1234'})
|
|
cs.share_instances.get(instance)
|
|
cs.assert_called('GET', '/share_instances/1234')
|
|
|
|
@ddt.data(
|
|
("2.6", type("InstanceUUID", (object, ), {"uuid": "1234"})),
|
|
("2.7", type("InstanceUUID", (object, ), {"uuid": "1234"})),
|
|
("2.6", type("InstanceID", (object, ), {"id": "1234"})),
|
|
("2.7", type("InstanceID", (object, ), {"id": "1234"})),
|
|
("2.6", "1234"),
|
|
("2.7", "1234"),
|
|
)
|
|
@ddt.unpack
|
|
def test_reset_instance_state(self, microversion, instance):
|
|
manager = self._get_manager(microversion)
|
|
state = 'available'
|
|
if (api_versions.APIVersion(microversion) >
|
|
api_versions.APIVersion("2.6")):
|
|
action_name = "reset_status"
|
|
else:
|
|
action_name = "os-reset_status"
|
|
|
|
with mock.patch.object(manager, "_action", mock.Mock()):
|
|
manager.reset_state(instance, state)
|
|
|
|
manager._action.assert_called_once_with(
|
|
action_name, instance, {"status": state})
|
|
|
|
@ddt.data(
|
|
("2.6", type('InstanceUUID', (object, ), {"uuid": "1234"})),
|
|
("2.6", "1234"),
|
|
("2.7", type('InstanceUUID', (object, ), {"uuid": "1234"})),
|
|
("2.7", "1234"),
|
|
)
|
|
@ddt.unpack
|
|
def test_force_delete_share_snapshot(self, microversion, instance):
|
|
manager = self._get_manager(microversion)
|
|
if (api_versions.APIVersion(microversion) >
|
|
api_versions.APIVersion("2.6")):
|
|
action_name = "force_delete"
|
|
else:
|
|
action_name = "os-force_delete"
|
|
|
|
with mock.patch.object(manager, "_action", mock.Mock()):
|
|
manager.force_delete(instance)
|
|
|
|
manager._action.assert_called_once_with(action_name, "1234")
|